Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve startup error logging #4093

Merged
merged 1 commit into from
Jul 5, 2022
Merged

improve startup error logging #4093

merged 1 commit into from
Jul 5, 2022

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Jul 5, 2022

Description

improves startup error logging

Related Issue

Motivation and Context

How Has This Been Tested?

  • first start ocis server then start ocis xxx server and see a speaking error message

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@ownclouders
Copy link
Contributor

💥 Acceptance test Core-API-Tests-ocis-storage-10 failed. Further test are cancelled...

@sonarcloud
Copy link

sonarcloud bot commented Jul 5, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
77.5% 77.5% Duplication

@wkloucek wkloucek requested review from C0rby, kobergj and rhafer and removed request for kulmann and pascalwengerter July 5, 2022 08:27
C0rby
C0rby approved these changes Jul 5, 2022
View reviewed changes
Copy link
Contributor

@C0rby C0rby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

@C0rby
Copy link
Contributor

C0rby commented Jul 5, 2022

The sonarcloud scanner is failing because of the high amount of duplication. This is unavoidable here so I'll force merge it.

@C0rby C0rby merged commit a9b66d4 into owncloud:master Jul 5, 2022
ownclouders pushed a commit that referenced this pull request Jul 5, 2022
commit a9b66d4
bce134a 
Merge: b70f8de f02591b
Author: David Christofas <dchristofas@owncloud.com>
Date:   Tue Jul 5 10:56:36 2022 +0200

    Merge pull request #4093 from wkloucek/improve-startup-errors

    improve startup error logging
@wkloucek wkloucek deleted the improve-startup-errors branch July 5, 2022 09:54
@micbar micbar mentioned this pull request Jul 19, 2022
Closed
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@C0rby C0rby C0rby approved these changes

@kobergj kobergj Awaiting requested review from kobergj

@rhafer rhafer Awaiting requested review from rhafer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unclear behaviour for conflicting services at startup
3 participants
@wkloucek @ownclouders @C0rby