Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant setting of cli.HelpFlag #4099

Merged
merged 1 commit into from
Jul 5, 2022
Merged

Conversation

rhafer
Copy link
Contributor

@rhafer rhafer commented Jul 5, 2022

The help flag is configured automatically by default already. We don't
need to redo that for every single service.

This also addresses one of the finding of "go race" (#4088)

@rhafer rhafer requested a review from kulmann as a code owner July 5, 2022 09:41
@rhafer rhafer self-assigned this Jul 5, 2022
@update-docs
Copy link

update-docs bot commented Jul 5, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

Copy link
Contributor

@C0rby C0rby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ownclouders
Copy link
Contributor

ownclouders commented Jul 5, 2022

💥 Acceptance test Core-API-Tests-ocis-storage-10 failed. Further test are cancelled...

The help flag is configured automatically by default already. We don't
need to redo that for every single service.

This also addresses one of the finding of "go race" (owncloud#4088)
@sonarcloud
Copy link

sonarcloud bot commented Jul 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@wkloucek wkloucek merged commit 3374467 into owncloud:master Jul 5, 2022
ownclouders pushed a commit that referenced this pull request Jul 5, 2022
Merge: 2070724 4a09d8a
Author: Willy Kloucek <34452982+wkloucek@users.noreply.github.com>
Date:   Tue Jul 5 15:50:02 2022 +0200

    Merge pull request #4099 from rhafer/clean

    Remove redundant setting of cli.HelpFlag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants