[tests-only] [full-ci] Do not skip tests for issue-3023 #4109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phil-davis
requested review from
wkloucek,
micbar and
individual-it
as code owners
|
The tests are still failing because of returning HTTP status 400 when it should be 409. This needs reva PR cs3org/reva#3031 pulled into oCIS. @aduffeck maybe you could add to this PR the changes needed to pull in the latest reva edge from last night? Then this will pass, and all associated issues can be closed. |
phil-davis
force-pushed
the
unskip-issue-3023
branch
from
b474210
to
2fad9db
Compare
individual-it
approved these changes
Jul 7, 2022
|
After #4115 is merged, I will rebase and this should pass. |
phil-davis
force-pushed
the
unskip-issue-3023
branch
from
2fad9db
to
0b72e2f
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
ownclouders
pushed a commit
that referenced
this pull request
Jul 7, 2022
ownclouders
pushed a commit
that referenced
this pull request
Jul 8, 2022
ownclouders
pushed a commit
that referenced
this pull request
Jul 8, 2022
ownclouders
pushed a commit
that referenced
this pull request
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue #3023 caused an infinite loop in the back-end, so the related test scenario was skipped. PR #4076 has pulled in the fix from oCIS, so we can unskip the test now.
The actual fix was applied to reva edge in cs3org/reva#3009
Related Issue
How Has This Been Tested?
CI
Types of changes
Checklist: