Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix OCIS_RUN_SERVICES #4133

Merged
merged 1 commit into from
Jul 7, 2022
Merged

fix OCIS_RUN_SERVICES #4133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions changelog/unreleased/fix-ocis-run-services.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
Bugfix: Fix `OCIS_RUN_SERVICES`

`OCIS_RUN_SERVICES` was introduced as successor to `OCIS_RUN_EXTENSIONS` because
we wanted to call oCIS "core" extensions services. We kept `OCIS_RUN_EXTENSIONS` for
backwards compatibility reasons.

It turned out, that setting `OCIS_RUN_SERVICES` has no effect since introduced. `OCIS_RUN_EXTENSIONS`.
`OCIS_RUN_EXTENSIONS` was working fine all the time.

We now fixed `OCIS_RUN_SERVICES`, so that you can use it as a equivalent replacement for `OCIS_RUN_EXTENSIONS`

https://github.com/owncloud/ocis/pull/4133
2 changes: 1 addition & 1 deletion ocis-pkg/config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ type Mode int
type Runtime struct {
Port string `yaml:"port" env:"OCIS_RUNTIME_PORT"`
Host string `yaml:"host" env:"OCIS_RUNTIME_HOST"`
Extensions string `yaml:"services" env:"OCIS_RUN_EXTENSIONS,OCIS_RUN_SERVICES"`
Extensions string `yaml:"services" env:"OCIS_RUN_EXTENSIONS;OCIS_RUN_SERVICES"`
}

// Config combines all available configuration parts.
Expand Down