Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] use spaceID #4148

Merged
merged 10 commits into from
Jul 12, 2022
Merged

[full-ci] use spaceID #4148

merged 10 commits into from
Jul 12, 2022

Conversation

micbar
Copy link
Contributor

@micbar micbar commented Jul 8, 2022 •
edited
Loading

Description

Clean up the CS3 api to use the spaceID

Related Issue

Motivation and Context

Have an awesome API

How Has This Been Tested?

  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@micbar micbar force-pushed the space-id branch 2 times, most recently from 9558615 to 3288c16 Compare July 8, 2022 13:36
@micbar micbar marked this pull request as ready for review July 8, 2022 13:37
@micbar micbar force-pushed the space-id branch 2 times, most recently from ae7171a to c4b14a3 Compare July 8, 2022 14:09
@ownclouders
Copy link
Contributor

💥 Acceptance test localApiTests-apiSpaces-ocis failed. Further test are cancelled...

@micbar micbar changed the title use spaceID [full-ci] use spaceID Jul 8, 2022
@micbar micbar force-pushed the space-id branch 3 times, most recently from 0d64348 to da38288 Compare July 11, 2022 07:51
butonic and others added 7 commits July 11, 2022 11:32
@butonic
add missing storageid
f02e0c8 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
update to cb988d5dfb11
18039ff 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@micbar
Merge branch 'master' into space-id
09aee5e
@butonic
update reva to b9df4027992b
1e4d28e 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
log owner when machine auth fails
761a092 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
update reva to 2832f4d
2b6f52a 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
cat generated config in drone for debugging
66b62ab 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
update expected failures
b67d418 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@micbar micbar mentioned this pull request Jul 12, 2022
Closed
36 tasks
@micbar micbar requested review from C0rby, aduffeck and rhafer July 12, 2022 12:06
@micbar micbar self-assigned this Jul 12, 2022
@micbar micbar added the Status:Needs-Review Needs review from a maintainer label Jul 12, 2022
kobergj
kobergj requested changes Jul 12, 2022
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@butonic
update reva to 66029006fc69
f7a6c08 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@sonarcloud
Copy link

sonarcloud bot commented Jul 12, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

31.2% 31.2% Coverage
0.0% 0.0% Duplication

@micbar micbar requested a review from aduffeck July 12, 2022 13:18
@micbar micbar merged commit 2a5eb63 into master Jul 12, 2022
@delete-merged-branch delete-merged-branch bot deleted the space-id branch July 12, 2022 13:25
ownclouders pushed a commit that referenced this pull request Jul 12, 2022
@micbar
commit 2a5eb63
df077b2 
Merge: 930a156 f7a6c08
Author: Michael Barz <mbarz@owncloud.com>
Date:   Tue Jul 12 15:25:24 2022 +0200

    Merge pull request #4148 from owncloud/space-id

    [full-ci] use spaceID
ownclouders pushed a commit that referenced this pull request Jul 12, 2022
@micbar
commit 2a5eb63
49f90cc 
Merge: 930a156 f7a6c08
Author: Michael Barz <mbarz@owncloud.com>
Date:   Tue Jul 12 15:25:24 2022 +0200

    Merge pull request #4148 from owncloud/space-id

    [full-ci] use spaceID
ownclouders pushed a commit that referenced this pull request Jul 12, 2022
@micbar
commit 2a5eb63
ccfd873 
Merge: 930a156 f7a6c08
Author: Michael Barz <mbarz@owncloud.com>
Date:   Tue Jul 12 15:25:24 2022 +0200

    Merge pull request #4148 from owncloud/space-id

    [full-ci] use spaceID
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduffeck aduffeck aduffeck approved these changes

@kobergj kobergj kobergj approved these changes

@wkloucek wkloucek Awaiting requested review from wkloucek wkloucek is a code owner

@phil-davis phil-davis Awaiting requested review from phil-davis phil-davis is a code owner

@individual-it individual-it Awaiting requested review from individual-it individual-it is a code owner

@C0rby C0rby Awaiting requested review from C0rby

@rhafer rhafer Awaiting requested review from rhafer

Assignees

@micbar micbar

Labels
Status:Needs-Review Needs review from a maintainer Topic:API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@micbar @ownclouders @aduffeck @kobergj @butonic