Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] [full-ci] Bump CORE_COMMITID for tests #4170

Merged
merged 1 commit into from
Jul 12, 2022
Merged

[tests-only] [full-ci] Bump CORE_COMMITID for tests #4170

merged 1 commit into from
Jul 12, 2022

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Jul 12, 2022 •
edited
Loading

Description

Related Issue

owncloud/QA#748

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@phil-davis phil-davis self-assigned this Jul 12, 2022
@phil-davis phil-davis mentioned this pull request Jul 12, 2022
Closed
16 tasks
@phil-davis phil-davis force-pushed the bump-core-commit-id-20220712 branch from 7a28a5b to 63cf224 Compare July 12, 2022 05:27
@sonarcloud
Copy link

sonarcloud bot commented Jul 12, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis marked this pull request as ready for review July 12, 2022 06:16
kiranparajuli589
kiranparajuli589 approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

tests/acceptance/expected-failures-API-on-OCIS-storage.md
Comment on lines -1066 to -1067
- [apiWebdavEtagPropagation2/copyFileFolder.feature:194](https://github.com/owncloud/core/blob/master/tests/acceptance/features/apiWebdavEtagPropagation2/copyFileFolder.feature#L194)
- [apiWebdavEtagPropagation2/copyFileFolder.feature:238](https://github.com/owncloud/core/blob/master/tests/acceptance/features/apiWebdavEtagPropagation2/copyFileFolder.feature#L238)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests removed in owncloud/core#40194 👍

@phil-davis phil-davis merged commit 930a156 into master Jul 12, 2022
@delete-merged-branch delete-merged-branch bot deleted the bump-core-commit-id-20220712 branch July 12, 2022 08:59
ownclouders pushed a commit that referenced this pull request Jul 12, 2022
@phil-davis
commit 930a156
9932755 
Merge: 592e87d 63cf224
Author: Phil Davis <phil@jankaritech.com>
Date:   Tue Jul 12 14:44:13 2022 +0545

    Merge pull request #4170 from owncloud/bump-core-commit-id-20220712

    [tests-only] [full-ci] Bump CORE_COMMITID for tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiranparajuli589 kiranparajuli589 kiranparajuli589 approved these changes

@SagarGi SagarGi Awaiting requested review from SagarGi

Assignees

@phil-davis phil-davis

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phil-davis @kiranparajuli589