Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci]Notify user on infected files #4277

Merged
merged 3 commits into from
Jul 26, 2022
Merged

[tests-only][full-ci]Notify user on infected files #4277

merged 3 commits into from
Jul 26, 2022

Conversation

kobergj
Copy link
Collaborator

@kobergj kobergj commented Jul 25, 2022

Description

Send the user an email when an infected file was found

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@kobergj
use extra event fields
172037a 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@kobergj
send email when infected file was found
6c7d7e0 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@update-docs
Copy link

update-docs bot commented Jul 25, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@kobergj kobergj changed the title Notify user on infected files [tests-only][full-ci]Notify user on infected files Jul 25, 2022
@kobergj
use experimental reva
1620030 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@sonarcloud
Copy link

sonarcloud bot commented Jul 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

fschade
fschade approved these changes Jul 26, 2022
View reviewed changes
Copy link
Contributor

@fschade fschade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THX 🤗 LGTM

@kobergj kobergj merged commit 58a8845 into owncloud:experimental Jul 26, 2022
@kobergj kobergj deleted the NotifyUserOnInfectedFiles branch July 26, 2022 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fschade fschade fschade approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kobergj @fschade