[full-ci] update web to v5.7.0-rc.10 #4439

kulmann · 2022-08-23T11:08:20Z

bump ownCloud Web to v5.7.0-rc.10

C0rby · 2022-08-23T13:54:13Z

I don't really get the CI errors... 😕
When I run oCIS locally it works fine but I'm not yet running the UI test suite so maybe I'm missing some crucial setup option or so.

C0rby · 2022-08-23T14:26:21Z

Ok, even with the test suite it's working locally... 😕

fschade · 2022-08-23T14:26:55Z

@C0rby, i see a lot of fishy errors... https://drone.owncloud.com/owncloud/ocis/14829/54/9

C0rby · 2022-08-23T14:28:50Z

@C0rby, i see a lot of fishy errors... https://drone.owncloud.com/owncloud/ocis/14829/54/9

certificate errors, and some others, don't wonder i reverted the last drone.star updates to test if this fixes the issues... i revert it if not

fschade · 2022-08-23T14:43:01Z

@individual-it, can you please have a look, we do not find why the tests are failing...

kulmann · 2022-08-23T15:17:57Z

@individual-it, can you please have a look, we do not find why the tests are failing...

a little more context for that:

web CI on the linked commit id was successful
ocis commit id in web is not up to date (5 days old)
all web scenarios in this PR are failing
test middleware is up to date

I'd suspect that this is some kind of config issue, but I don't see anything that has changed in that regard. Maybe you have an idea...

kulmann · 2022-08-23T20:00:20Z

Just now I realized that the e2e tests are passing. So the issue is only with the nightwatch acceptance tests apparently.

kulmann · 2022-08-23T20:10:02Z

Created a PR in web with screenshots from CI enabled. maybe that gives us a clue...

kulmann · 2022-08-23T20:29:21Z

Created a PR in web with screenshots from CI enabled. maybe that gives us a clue...

aaand acceptance tests for this PR here seem to pass in the web CI.

SwikritiT · 2022-08-24T03:36:46Z

I'll take a look at what's happening

phil-davis · 2022-08-24T04:08:47Z

Note: This branch is 3 commits ahead, 3 commits behind master.

This branch does not have #4444 "update reva". It would be good to also know/test that this web update works with the really latest reva.

kulmann · 2022-08-24T04:20:00Z

Note: This branch is 3 commits ahead, 3 commits behind master.

This branch does not have #4444 "update reva". It would be good to also know/test that this web update works with the really latest reva.

Yes, true. Feel free to rebase :-)

SwikritiT · 2022-08-24T04:26:03Z

Locally while running the tests there's this popup

And the test fail in the similar way as in CI

Scenario: Delete multiple files at once on a public share # features/webUIDeleteFilesFolders/deleteFilesFolders.feature:204
   ✔ Before # setup.js:38
   ✔ Before # setup.js:42
   ✔ Before # setup.js:53
   ✔ Before # setup.js:60
   ✔ Before # setup.js:71
   ✔ Before # stepDefinitions/filesContext.js:17
   ✔ Before # stepDefinitions/generalContext.js:206
   ✔ Before # stepDefinitions/generalContext.js:244
   ✔ Before # stepDefinitions/middlewareContext.js:46
   ✔ Given user "Alice" has been created with default attributes and without skeleton files in the server # stepDefinitions/middlewareContext.js:66
   ✔ Given user "Alice" has created folder "simple-folder" in the server # stepDefinitions/middlewareContext.js:66
   ✔ And user "Alice" has created file "simple-folder/data.zip" in the server # stepDefinitions/middlewareContext.js:66
   ✔ And user "Alice" has created file "simple-folder/lorem.txt" in the server # stepDefinitions/middlewareContext.js:66
   ✔ And user "Alice" has created file "simple-folder/simple-empty-folder" in the server # stepDefinitions/middlewareContext.js:66
   ✔ And user "Alice" has shared folder "simple-folder" with link with "read, update, create, delete" permissions in the server # stepDefinitions/middlewareContext.js:66
   ✔ When the public uses the webUI to access the last public link created by user "Alice" in a new session # stepDefinitions/publicLinkContext.js:51
   ✖ And the user batch deletes these files using the webUI # stepDefinitions/filesContext.js:487
       | name                |
       | data.zip            |
       | lorem.txt           |
       | simple-empty-folder |
       Timed out while waiting for element <//button[contains(@class, "oc-files-actions-delete-")]> to be present for 10000 milliseconds. - expected "visible" but got: "not found" (10025ms)
           at Proxy.deleteAllCheckedFiles (/home/swikriti/www/web/tests/acceptance/pageObjects/personalPage.js:232:19)
           at World.<anonymous> (/home/swikriti/www/web/tests/acceptance/stepDefinitions/filesContext.js:493:37)
           at runMicrotasks (<anonymous>)
           at processTicksAndRejections (node:internal/process/task_queues:96:5)
   - Then as "Alice" file "simple-folder/data.zip" should not exist in the server # stepDefinitions/middlewareContext.js:66
   - And as "Alice" file "simple-folder/lorem.txt" should not exist in the server # stepDefinitions/middlewareContext.js:66
   - And as "Alice" folder "simple-folder/simple-empty-folder" should not exist in the server # stepDefinitions/middlewareContext.js:66
   - And the deleted elements should not be listed on the webUI # stepDefinitions/filesContext.js:402
   - And the deleted elements should not be listed on the webUI after a page reload # stepDefinitions/filesContext.js:406
   ✔ After # stepDefinitions/middlewareContext.js:60
   ✔ After # stepDefinitions/generalContext.js:262
   ✔ After # stepDefinitions/generalContext.js:231
   ✔ After # stepDefinitions/generalContext.js:172
   ✔ After # setup.js:104
   ✔ After # setup.js:100
   ✔ After # setup.js:96
   ✔ After # setup.js:89
   ✔ After # setup.js:80

I'll rebase and push and look more into it

SwikritiT · 2022-08-24T05:37:55Z

golangci-lint keeps on failing in one pipeline or another in every run 😢

Restarting the build again

kulmann · 2022-08-24T06:46:06Z

@SwikritiT could you tell me which requests are failing with a 401 (see network tab in browser dev tools) if you cancel the basic auth popup?

SwikritiT · 2022-08-24T07:08:12Z

@kulmann This is failing with 401

Request URL: https://host.docker.internal:9200/accounts.js
Request Method: GET
Status Code: 401 Unauthorized
Remote Address: 127.0.0.1:9200
Referrer Policy: strict-origin-when-cross-origin

OCIS LOG

2022/08/24 12:50:35 http: TLS handshake error from 127.0.0.1:60008: remote error: tls: unknown certificate
2022/08/24 12:50:35 http: TLS handshake error from 127.0.0.1:60012: remote error: tls: unknown certificate
2022/08/24 12:50:35 http: TLS handshake error from 127.0.0.1:60014: remote error: tls: unknown certificate
2022/08/24 12:50:35 http: TLS handshake error from 127.0.0.1:60016: remote error: tls: unknown certificate
2022/08/24 12:50:35 http: TLS handshake error from 127.0.0.1:60020: remote error: tls: unknown certificate
2022/08/24 12:50:35 http: TLS handshake error from 127.0.0.1:60018: remote error: tls: unknown certificate
2022/08/24 12:50:35 http: TLS handshake error from 127.0.0.1:60024: remote error: tls: unknown certificate

kulmann · 2022-08-24T07:15:19Z

@SwikritiT awesome, that's it! The accounts frontend app doesn't exist anymore. That it's still part of the config.json for drone didn't fall on our feet before because it just fails with a 404. Now it failed with a 401, which causes a basic auth popup and blocks further interaction. I've added a commit that deletes the accounts app from the config.json in CI.

@C0rby this brings up another issue: can we have a wildcard allowance for certain file types, like .js, .css, .html? Because any external app that gets added to the config.json would fail with a 401 at the moment, right?

The same is probably still true for the settings app, right? It is not part of the bundled apps, gets loaded via https://ocis-server/settings.js if I recall correctly.

SwikritiT · 2022-08-24T07:18:13Z

The Ci has already failed in generate-go and golint. I'll restart the build

kulmann · 2022-08-24T07:18:21Z

@C0rby When I open the settings app via the user menu (top right) and do a page reload I also get a 401 + basic auth popup.

SwikritiT · 2022-08-24T07:23:18Z

The CI failed again at https://drone.owncloud.com/owncloud/ocis/14883/35/3 go-generate and golangci-lint has become really annoying lately. Is there nothing we do about it?

C0rby · 2022-08-24T08:48:55Z

@C0rby When I open the settings app via the user menu (top right) and do a page reload I also get a 401 + basic auth popup.

Ah interesting. That means another path is missing. I'll add it.

C0rby · 2022-08-24T08:49:53Z

@C0rby this brings up another issue: can we have a wildcard allowance for certain file types, like .js, .css, .html? Because any external app that gets added to the config.json would fail with a 401 at the moment, right?

I wouldn't really implement a wildcard for security reasons but yeah we need to refactor the proxy quite a bit to make this easier.

kulmann · 2022-08-24T09:02:57Z

@C0rby this brings up another issue: can we have a wildcard allowance for certain file types, like .js, .css, .html? Because any external app that gets added to the config.json would fail with a 401 at the moment, right?

I wouldn't really implement a wildcard for security reasons but yeah we need to refactor the proxy quite a bit to make this easier.

Then we probably need to be able to register unprotected routes... or namespace any js bundle into the /js/ path

C0rby · 2022-08-24T09:05:19Z

Then we probably need to be able to register unprotected routes

Yeah, that is the plan. To use the proxy routes and mark certain routes as "unprotected".

sonarcloud · 2022-08-24T09:09:13Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

kulmann · 2022-08-24T09:14:18Z

@SwikritiT @C0rby nice, settings ui tests are passing now. All the other pipelines were green in the run before. Should be good now. Thanks for your efforts!

Merge: ad3c948 e65eb15 Author: Benedikt Kulmann <benedikt@kulmann.biz> Date: Wed Aug 24 12:08:22 2022 +0200 Merge pull request #4439 from owncloud/update-web-v5.7.0-rc.10 [full-ci] update web to v5.7.0-rc.10

kulmann requested review from C0rby, dragonchaser and fschade August 23, 2022 11:08

kulmann force-pushed the update-web-v5.7.0-rc.10 branch from 1d0719f to cf77d2e Compare August 23, 2022 13:30

kulmann self-assigned this Aug 23, 2022

fschade requested review from wkloucek, micbar, phil-davis and individual-it as code owners August 23, 2022 14:31

fschade force-pushed the update-web-v5.7.0-rc.10 branch from 0aef87e to cf77d2e Compare August 23, 2022 14:42

SwikritiT self-assigned this Aug 24, 2022

kulmann and others added 3 commits August 24, 2022 10:12

chore: update web to v5.7.0-rc.10

992c19d

add the fonts path to the unprotected path prefixes

6043e01

end unprotected path prefixes with a slash

28a9bf3

SwikritiT force-pushed the update-web-v5.7.0-rc.10 branch from cf77d2e to 28a9bf3 Compare August 24, 2022 04:28

ci: delete accounts frontend app from ci config.json

dd49462

add the settings path to the unprotected paths

e65eb15

kulmann requested a review from kobergj August 24, 2022 10:04

phil-davis approved these changes Aug 24, 2022

View reviewed changes

kulmann merged commit 335567e into master Aug 24, 2022

delete-merged-branch bot deleted the update-web-v5.7.0-rc.10 branch August 24, 2022 10:08

kulmann mentioned this pull request Aug 25, 2022

Release 2.0.0-beta.7 #4425

Closed

29 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[full-ci] update web to v5.7.0-rc.10 #4439

[full-ci] update web to v5.7.0-rc.10 #4439

kulmann commented Aug 23, 2022

C0rby commented Aug 23, 2022

C0rby commented Aug 23, 2022

fschade commented Aug 23, 2022

C0rby commented Aug 23, 2022 •

edited by fschade

Loading

fschade commented Aug 23, 2022

kulmann commented Aug 23, 2022

kulmann commented Aug 23, 2022

kulmann commented Aug 23, 2022 •

edited

Loading

kulmann commented Aug 23, 2022

SwikritiT commented Aug 24, 2022

phil-davis commented Aug 24, 2022

kulmann commented Aug 24, 2022

SwikritiT commented Aug 24, 2022 •

edited

Loading

SwikritiT commented Aug 24, 2022 •

edited

Loading

kulmann commented Aug 24, 2022

SwikritiT commented Aug 24, 2022

kulmann commented Aug 24, 2022 •

edited

Loading

SwikritiT commented Aug 24, 2022

kulmann commented Aug 24, 2022

SwikritiT commented Aug 24, 2022

C0rby commented Aug 24, 2022

C0rby commented Aug 24, 2022

kulmann commented Aug 24, 2022 •

edited

Loading

C0rby commented Aug 24, 2022

sonarcloud bot commented Aug 24, 2022

kulmann commented Aug 24, 2022

[full-ci] update web to v5.7.0-rc.10 #4439

[full-ci] update web to v5.7.0-rc.10 #4439

Conversation

kulmann commented Aug 23, 2022

C0rby commented Aug 23, 2022

C0rby commented Aug 23, 2022

fschade commented Aug 23, 2022

C0rby commented Aug 23, 2022 • edited by fschade Loading

fschade commented Aug 23, 2022

kulmann commented Aug 23, 2022

kulmann commented Aug 23, 2022

kulmann commented Aug 23, 2022 • edited Loading

kulmann commented Aug 23, 2022

SwikritiT commented Aug 24, 2022

phil-davis commented Aug 24, 2022

kulmann commented Aug 24, 2022

SwikritiT commented Aug 24, 2022 • edited Loading

SwikritiT commented Aug 24, 2022 • edited Loading

kulmann commented Aug 24, 2022

SwikritiT commented Aug 24, 2022

OCIS LOG

kulmann commented Aug 24, 2022 • edited Loading

SwikritiT commented Aug 24, 2022

kulmann commented Aug 24, 2022

SwikritiT commented Aug 24, 2022

C0rby commented Aug 24, 2022

C0rby commented Aug 24, 2022

kulmann commented Aug 24, 2022 • edited Loading

C0rby commented Aug 24, 2022

sonarcloud bot commented Aug 24, 2022

kulmann commented Aug 24, 2022

C0rby commented Aug 23, 2022 •

edited by fschade

Loading

kulmann commented Aug 23, 2022 •

edited

Loading

SwikritiT commented Aug 24, 2022 •

edited

Loading

SwikritiT commented Aug 24, 2022 •

edited

Loading

kulmann commented Aug 24, 2022 •

edited

Loading

kulmann commented Aug 24, 2022 •

edited

Loading