[tests-only] [full-ci] ApiTest. after each test users-manager delete their project space

[ScharfViktor]

Part2 of issue #4390

• method works well and clears project spaces

But there is one little problem when we run tests without creating project space and method https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/bootstrap/SpacesContext.php#L897-L904 tries to remember no spaces:

[ScharfViktor]

CI is green but stucks due docker arm https://drone.owncloud.com/owncloud/ocis/14823

[phil-davis]

I'm not sure why we need the assertArrayHasKey check in rememberTheAvailableSpaces() - if $drives is empty, then that means there are none that matched whatever was the last query/filter. The same with Assert::assertNotEmpty($spaces, "No spaces have been found"); - it might be normal that there are no spaces found. It needs some refactoring to maybe know when it should expect to find something, and when it is being called in a situation where there might be nothing.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[ScharfViktor]

I'm not sure why we need the assertArrayHasKey check in rememberTheAvailableSpaces() - if $drives is empty, then that means there are none that matched whatever was the last query/filter. The same with Assert::assertNotEmpty($spaces, "No spaces have been found"); - it might be normal that there are no spaces found. It needs some refactoring to maybe know when it should expect to find something, and when it is being called in a situation where there might be nothing.

I deleted asserts in rememberSpaces method. now pr's ready for review.

[phil-davis]

LGTM