Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add config options for mail encryption and authentication #4443

Merged
merged 1 commit into from
Aug 24, 2022
Merged

add config options for mail encryption and authentication #4443

merged 1 commit into from
Aug 24, 2022

Conversation

wkloucek
Copy link
Contributor

Description

Enhancement: Add configuration options for mail authentication and encryption

We've added configuration options to configure the authentication and encryption
for sending mails in the notifications service.

Furthermore there is now a distinguished configuration option for the username to use
for authentication against the mail server. This allows you to customize the sender address
to your liking. For example sender addresses like my oCIS instance <ocis@owncloud.test> are now possible, too.

Related Issue

  • Could not send agains servers using STARTTLS / TLS with authentication

Motivation and Context

How Has This Been Tested?

  • tested agains a production mail server

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Aug 23, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ownclouders
Copy link
Contributor

💥 Acceptance test localApiTests-apiArchiver-ocis failed. Further test are cancelled...

Copy link
Contributor

@fschade fschade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Aug 24, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability C 1 Vulnerability
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@wkloucek wkloucek merged commit c0df456 into owncloud:master Aug 24, 2022
@wkloucek wkloucek deleted the mail-auth-encrypt branch August 24, 2022 08:49
ownclouders pushed a commit that referenced this pull request Aug 24, 2022
Merge: f3e6237 faa7d3b
Author: Willy Kloucek <34452982+wkloucek@users.noreply.github.com>
Date:   Wed Aug 24 10:49:50 2022 +0200

    Merge pull request #4443 from wkloucek/mail-auth-encrypt

    add config options for mail encryption and authentication
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants