Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve login screen design #4500

Merged
merged 4 commits into from
Sep 2, 2022
Merged

Improve login screen design #4500

merged 4 commits into from
Sep 2, 2022

Conversation

JammingBen
Copy link
Contributor

@JammingBen JammingBen commented Sep 2, 2022 •
edited
Loading

Description

We've improved the design of the login screen to match with the general design used in Web.

Related Issue

Screenshots

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

@JammingBen JammingBen self-assigned this Sep 2, 2022
@JammingBen JammingBen marked this pull request as ready for review September 2, 2022 08:45
kulmann
kulmann reviewed Sep 2, 2022
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you check if it's easy to do to also use the Inter font here?

kulmann
kulmann approved these changes Sep 2, 2022
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sonarcloud
Copy link

sonarcloud bot commented Sep 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@JammingBen JammingBen merged commit 123ae47 into master Sep 2, 2022
@delete-merged-branch delete-merged-branch bot deleted the login-screen-design branch September 2, 2022 12:58
ownclouders pushed a commit that referenced this pull request Sep 2, 2022
@JammingBen
commit 123ae47
f4aef74 
Merge: 2051f0d a9fd209
Author: Jannik Stehle <50302941+JammingBen@users.noreply.github.com>
Date:   Fri Sep 2 14:58:19 2022 +0200

    Merge pull request #4500 from owncloud/login-screen-design

    Improve login screen design
@tbsbdr
Copy link
Contributor

tbsbdr commented Sep 2, 2022

Its ok as is - thanks!

generally: we should avoid placeholder. duplication is redundant, having examples like "john@doe.com" is for some ppl confusing. good read: https://www.nngroup.com/articles/form-design-placeholders/

@JammingBen JammingBen mentioned this pull request Sep 2, 2022
Closed
@micbar micbar mentioned this pull request Sep 12, 2022
Closed
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@AlexAndBear AlexAndBear Awaiting requested review from AlexAndBear

Assignees

@JammingBen JammingBen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Login form design improvement
3 participants
@JammingBen @tbsbdr @kulmann