Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci]Reuse locking method from core #4510

Merged
merged 1 commit into from
Sep 5, 2022
Merged

[tests-only][full-ci]Reuse locking method from core #4510

merged 1 commit into from
Sep 5, 2022

Conversation

SagarGi
Copy link
Member

@SagarGi SagarGi commented Sep 5, 2022

Description

This PR makes adjustment to use the existing locking method from core and removes the duplicated code.

Related Issue

#4509

@SagarGi SagarGi self-assigned this Sep 5, 2022
@SagarGi SagarGi added the QA:team label Sep 5, 2022
@SagarGi SagarGi mentioned this pull request Sep 5, 2022
Closed
@SagarGi SagarGi requested a review from saw-jan September 5, 2022 07:13
@sonarcloud
Copy link

sonarcloud bot commented Sep 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis self-requested a review September 5, 2022 08:24
phil-davis
phil-davis approved these changes Sep 5, 2022
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good if CI passes.

@phil-davis phil-davis merged commit ac0b659 into master Sep 5, 2022
@delete-merged-branch delete-merged-branch bot deleted the reuseCodeForLockFromCore branch September 5, 2022 09:13
ownclouders pushed a commit that referenced this pull request Sep 5, 2022
@phil-davis
commit ac0b659
7fcda4e 
Merge: e27e5a2 23196c7
Author: Phil Davis <phil@jankaritech.com>
Date:   Mon Sep 5 14:58:13 2022 +0545

    Merge pull request #4510 from owncloud/reuseCodeForLockFromCore

    [tests-only][full-ci]Reuse locking method from core
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@grgprarup grgprarup Awaiting requested review from grgprarup

@saw-jan saw-jan Awaiting requested review from saw-jan

Assignees

@SagarGi SagarGi

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SagarGi @phil-davis