Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix env variables for JSONCS3 public driver configuration #4593

Merged
merged 5 commits into from
Oct 6, 2022
Merged

fix env variables for JSONCS3 public driver configuration #4593

merged 5 commits into from
Oct 6, 2022

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Sep 15, 2022

Description

We've fixed the environment variable config options of the jsoncs3 driver that previously
used the same environment variables as the cs3 driver.
Now the jsoncs3 driver has it's own configuration environment variables.

If you used the jsoncs3 sharing driver and explicitly set SHARING_PUBLIC_CS3_SYSTEM_USER_ID,
this PR is a breaking change for your deployment. To workaround you may set the value you had
configured in SHARING_PUBLIC_CS3_SYSTEM_USER_ID to both SHARING_PUBLIC_JSONCS3_SYSTEM_USER_ID
and SHARING_PUBLIC_JSONCS3_SYSTEM_USER_IDP.

Related Issue

  • Fixes jsoncs3 config options

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Sep 15, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

Co-authored-by: Jörn Friedrich Dreyer <jfd@butonic.de>
micbar
micbar previously approved these changes Sep 20, 2022
@ownclouders
Copy link
Contributor

💥 Acceptance test localApiTests-apiSpaces-ocis failed. Further test are cancelled...

@wkloucek wkloucek marked this pull request as ready for review September 26, 2022 06:46
@wkloucek
Copy link
Contributor Author

@micbar @butonic we also might wait until we drop the idp part from the storage-(users|system), so that change will no longer be breaking for the described corner case

@wkloucek wkloucek dismissed micbar’s stale review September 26, 2022 06:48

turns out this is a breaking change for some cases, please review again

@sonarcloud
Copy link

sonarcloud bot commented Sep 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@wkloucek
Copy link
Contributor Author

wkloucek commented Oct 5, 2022

should no longer be an breaking change with cs3org/reva#3266. Though we could remove some the IDP config options!?

@butonic
Copy link
Member

butonic commented Oct 6, 2022

@wkloucek the storage syetem idp is still necessary. we may want to revisit the userid & useridp after ga, though. IMO we should exchange whatever credentials are used for an internal uuid in the proxy.

@butonic butonic merged commit de76dc7 into owncloud:master Oct 6, 2022
ownclouders pushed a commit that referenced this pull request Oct 6, 2022
Author: Willy Kloucek <34452982+wkloucek@users.noreply.github.com>
Date:   Thu Oct 6 10:02:31 2022 +0200

    fix env variables for JSONCS3 public driver configuration (#4593)

    * fix env variables for JSONCS3 public driver configuration

    * Update services/sharing/pkg/config/config.go

    Co-authored-by: Jörn Friedrich Dreyer <jfd@butonic.de>

    * extend list of available sharing drivers

    * add changelog

    Co-authored-by: Michael Barz <michael.barz@zeitgestalten.eu>
    Co-authored-by: Jörn Friedrich Dreyer <jfd@butonic.de>
butonic added a commit that referenced this pull request Oct 6, 2022
* fix env variables for JSONCS3 public driver configuration (#4593)

* fix env variables for JSONCS3 public driver configuration

* Update services/sharing/pkg/config/config.go

Co-authored-by: Jörn Friedrich Dreyer <jfd@butonic.de>

* extend list of available sharing drivers

* add changelog

Co-authored-by: Michael Barz <michael.barz@zeitgestalten.eu>
Co-authored-by: Jörn Friedrich Dreyer <jfd@butonic.de>

* Automated changelog update [skip ci]

* use latest experimental reva

Signed-off-by: jkoberg <jkoberg@owncloud.com>

Signed-off-by: jkoberg <jkoberg@owncloud.com>
Co-authored-by: Willy Kloucek <34452982+wkloucek@users.noreply.github.com>
Co-authored-by: Michael Barz <michael.barz@zeitgestalten.eu>
Co-authored-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@micbar micbar mentioned this pull request Nov 25, 2022
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants