-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix env variables for JSONCS3 public driver configuration #4593
fix env variables for JSONCS3 public driver configuration #4593
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
Co-authored-by: Jörn Friedrich Dreyer <jfd@butonic.de>
💥 Acceptance test localApiTests-apiSpaces-ocis failed. Further test are cancelled... |
turns out this is a breaking change for some cases, please review again
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
should no longer be an breaking change with cs3org/reva#3266. Though we could remove some the IDP config options!? |
@wkloucek the storage syetem idp is still necessary. we may want to revisit the userid & useridp after ga, though. IMO we should exchange whatever credentials are used for an internal uuid in the proxy. |
Author: Willy Kloucek <34452982+wkloucek@users.noreply.github.com> Date: Thu Oct 6 10:02:31 2022 +0200 fix env variables for JSONCS3 public driver configuration (#4593) * fix env variables for JSONCS3 public driver configuration * Update services/sharing/pkg/config/config.go Co-authored-by: Jörn Friedrich Dreyer <jfd@butonic.de> * extend list of available sharing drivers * add changelog Co-authored-by: Michael Barz <michael.barz@zeitgestalten.eu> Co-authored-by: Jörn Friedrich Dreyer <jfd@butonic.de>
* fix env variables for JSONCS3 public driver configuration (#4593) * fix env variables for JSONCS3 public driver configuration * Update services/sharing/pkg/config/config.go Co-authored-by: Jörn Friedrich Dreyer <jfd@butonic.de> * extend list of available sharing drivers * add changelog Co-authored-by: Michael Barz <michael.barz@zeitgestalten.eu> Co-authored-by: Jörn Friedrich Dreyer <jfd@butonic.de> * Automated changelog update [skip ci] * use latest experimental reva Signed-off-by: jkoberg <jkoberg@owncloud.com> Signed-off-by: jkoberg <jkoberg@owncloud.com> Co-authored-by: Willy Kloucek <34452982+wkloucek@users.noreply.github.com> Co-authored-by: Michael Barz <michael.barz@zeitgestalten.eu> Co-authored-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Description
We've fixed the environment variable config options of the jsoncs3 driver that previously
used the same environment variables as the cs3 driver.
Now the jsoncs3 driver has it's own configuration environment variables.
If you used the jsoncs3 sharing driver and explicitly set
SHARING_PUBLIC_CS3_SYSTEM_USER_ID
,this PR is a breaking change for your deployment. To workaround you may set the value you had
configured in
SHARING_PUBLIC_CS3_SYSTEM_USER_ID
to bothSHARING_PUBLIC_JSONCS3_SYSTEM_USER_ID
and
SHARING_PUBLIC_JSONCS3_SYSTEM_USER_IDP
.Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: