Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the oidc provider cache #4600

Merged
merged 1 commit into from
Sep 16, 2022
Merged

fix the oidc provider cache #4600

merged 1 commit into from
Sep 16, 2022

Conversation

wkloucek
Copy link
Contributor

Description

fixes the oidc provider cache. It never had a cache hit before this fix.

Related Issue

Motivation and Context

Caused a painfully slow oCIS if the IDP wellknown endpoint was not too fast.

How Has This Been Tested?

  • debug and see if we have cache hits

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Sep 16, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@wkloucek wkloucek marked this pull request as ready for review September 16, 2022 10:34
@sonarcloud
Copy link

sonarcloud bot commented Sep 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@wkloucek wkloucek merged commit d702656 into owncloud:master Sep 16, 2022
@wkloucek wkloucek deleted the fix-oidc-provider-cache branch September 16, 2022 11:40
ownclouders pushed a commit that referenced this pull request Sep 16, 2022
@wkloucek
commit d702656
039135b 
Merge: 83a9be8 2d16779
Author: Willy Kloucek <34452982+wkloucek@users.noreply.github.com>
Date:   Fri Sep 16 13:39:14 2022 +0200

    Merge pull request #4600 from wkloucek/fix-oidc-provider-cache

    fix the oidc provider cache
@micbar micbar mentioned this pull request Nov 25, 2022
Closed
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kobergj kobergj kobergj approved these changes

@C0rby C0rby Awaiting requested review from C0rby

@micbar micbar Awaiting requested review from micbar

@butonic butonic Awaiting requested review from butonic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wkloucek @kobergj