Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bring back the settings ui #4691

Merged
merged 1 commit into from
Sep 27, 2022
Merged

bring back the settings ui #4691

merged 1 commit into from
Sep 27, 2022

Conversation

wkloucek
Copy link
Contributor

Description

Bugfix: Bring back the settings UI in Web

We've fixed the oC Web configuration in oCIS so that the settings UI will be shown again in Web.

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Sep 27, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@sonarcloud
Copy link

sonarcloud bot commented Sep 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@butonic butonic merged commit 0a46ef0 into owncloud:master Sep 27, 2022
ownclouders pushed a commit that referenced this pull request Sep 27, 2022
@wkloucek
commit 0a46ef0
e386967 
Author: Willy Kloucek <34452982+wkloucek@users.noreply.github.com>
Date:   Tue Sep 27 18:50:45 2022 +0200

    bring back the settings ui (#4691)
@wkloucek wkloucek deleted the bring-back-the-settings-ui branch September 27, 2022 17:18
@micbar micbar mentioned this pull request Nov 25, 2022
Closed
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@butonic butonic butonic approved these changes

@kulmann kulmann Awaiting requested review from kulmann kulmann is a code owner

@rhafer rhafer Awaiting requested review from rhafer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wkloucek @butonic