Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] update reva, wopi folderurl #4716

Merged
merged 1 commit into from
Oct 5, 2022
Merged

[full-ci] update reva, wopi folderurl #4716

merged 1 commit into from
Oct 5, 2022

Conversation

micbar
Copy link
Contributor

@micbar micbar commented Sep 29, 2022 •
edited
Loading

Description

Make the wopi folder url of the WOPI App driver configurable.

Related Issue

Motivation and Context

Provide a meaningful landing page after exiting the Web Editor

@kulmann This currently uses a template to create a Web Url

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@saw-jan saw-jan mentioned this pull request Sep 30, 2022
Closed
@micbar micbar force-pushed the wopi-driver-improvements branch 4 times, most recently from 97ff3be to 0f725f9 Compare October 4, 2022 12:08
@micbar micbar marked this pull request as ready for review October 4, 2022 12:09
@micbar micbar requested review from kobergj and C0rby October 4, 2022 12:10
@micbar micbar force-pushed the wopi-driver-improvements branch 2 times, most recently from 8d7f6ca to ae8df4e Compare October 4, 2022 12:12
@micbar micbar requested a review from butonic October 4, 2022 12:14
@micbar
Copy link
Contributor Author

micbar commented Oct 4, 2022

@mmattel Ping for new ENV variables review.

@micbar micbar requested a review from mmattel October 4, 2022 12:27
@butonic
Copy link
Member

butonic commented Oct 4, 2022

I don't see a problem with this PR but it seems something broke with the reva update

@sonarcloud
Copy link

sonarcloud bot commented Oct 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@micbar micbar merged commit a923316 into master Oct 5, 2022
ownclouders pushed a commit that referenced this pull request Oct 5, 2022
@micbar
commit a923316
d9253a2 
Merge: 083b989 ad7b94a
Author: Michael Barz <mbarz@owncloud.com>
Date:   Wed Oct 5 09:22:05 2022 +0200

    Merge pull request #4716 from owncloud/wopi-driver-improvements

    [full-ci] update reva, wopi folderurl
@ScharfViktor
Copy link
Contributor

I tried to test it and here my notes:

Screen.Recording.2022-10-05.at.12.45.31.mov
  • probably we should add envAPP_PROVIDER_WOPI_FOLDER_URL_BASE_URL: https://${OCIS_DOMAIN:-ocis.owncloud.test} to ocis-appdriver-onlyoffice ?
  • looks better in this case, but we have no file(bug?)
Screen.Recording.2022-10-05.at.12.50.24.mov
  • and I would suggest to up onlyoffice version to onlyoffice/documentserver:7.2

@wkloucek wkloucek deleted the wopi-driver-improvements branch November 11, 2022 12:59
@micbar micbar mentioned this pull request Nov 25, 2022
Closed
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@butonic butonic butonic approved these changes

@kobergj kobergj Awaiting requested review from kobergj

@C0rby C0rby Awaiting requested review from C0rby

@mmattel mmattel Awaiting requested review from mmattel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@micbar @butonic @ScharfViktor @kobergj