Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] Rescan spaces #4777

Merged
merged 21 commits into from
Oct 14, 2022
Merged

[full-ci] Rescan spaces #4777

merged 21 commits into from
Oct 14, 2022

Conversation

aduffeck
Copy link
Contributor

This PR makes the search service trigger a reindex/sync of spaces when an event was received for an item inside that space.
That fixes the problem that mtime and treesize propagation was not reflected in the search index properly.

Fixes #4410

@update-docs
Copy link

update-docs bot commented Oct 11, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@aduffeck
Copy link
Contributor Author

Note: Depends on cs3org/reva#3340

@ownclouders
Copy link
Contributor

ownclouders commented Oct 13, 2022

💥 Acceptance test Core-API-Tests-ocis-storage-1 failed. Further test are cancelled...

@aduffeck aduffeck changed the title Rescan spaces [full-ci] Rescan spaces Oct 14, 2022
@sonarcloud
Copy link

sonarcloud bot commented Oct 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

62.5% 62.5% Coverage
0.0% 0.0% Duplication

@butonic butonic merged commit 5e22092 into owncloud:master Oct 14, 2022
ownclouders pushed a commit that referenced this pull request Oct 14, 2022
Author: Andre Duffeck <aduffeck@users.noreply.github.com>
Date:   Fri Oct 14 17:03:05 2022 +0200

    [full-ci] Rescan spaces (#4777)

    * Increase the timeout for indexing spaces

    * Allow for making queries that are not constrained to a RootID

    * Use nano precision for the Mtime

    * Add a SpaceDebouncer

    The debouncer can be used to delay operations on spaces until things
    have settled down to avoid doing the same operation multiple times.

    * Do not index subtrees until they have changed (i.e. the mtime differs)

    * Also pass a user to the space debouncer func

    * Trigger a rescan of the according space when an event is received

    * Improve wording/logging

    * Add changelog

    * Get rid of superfluous GetUserByClaim call

    * Fix tests

    * Fix reindexing triggered by shares by using the event's SpaceOwner

    * Bump reva to pull in the space owner events changes

    * Fix changelog

    * Fix linter issues

    * Fall back to the executant if no owner was received from the event

    * Bump reva and go-cs3apis

    * Fix go.sum

    * Bump core

    * Adapt expected failures

    * Tweak debounce settings
@aduffeck aduffeck deleted the rescan-spaces branch October 17, 2022 06:43
@micbar micbar mentioned this pull request Nov 25, 2022
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search index does not update size and mtime of parents when entities change
3 participants