Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't cache the web index.html #4809

Merged
merged 4 commits into from
Oct 13, 2022
Merged

don't cache the web index.html #4809

merged 4 commits into from
Oct 13, 2022

Conversation

wkloucek
Copy link
Contributor

Description

we should not cache the index.html for oC web. If we cache the index.html it may require bundles that are no longer available after an update.

Related Issue

  • Fixes with caching

Motivation and Context

How Has This Been Tested?

  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Oct 13, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@micbar
Copy link
Contributor

micbar commented Oct 13, 2022

@kulmann @fschade This should fix the Oops, something went wrong occurences.

@fschade
Copy link
Contributor

fschade commented Oct 13, 2022

@wkloucek please have a look, i added try_files support, e.g. foo/bar/baz => index.html => no-cache. Ok!?
@micbar, yes it does 🥳

@wkloucek wkloucek marked this pull request as ready for review October 13, 2022 12:31
kulmann
kulmann approved these changes Oct 13, 2022
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be worth a changelog item. code looks good 👍

@fschade
Copy link
Contributor

fschade commented Oct 13, 2022

@kulmann, added, thx.

@sonarcloud
Copy link

sonarcloud bot commented Oct 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@fschade fschade merged commit 5eb43fb into owncloud:master Oct 13, 2022
ownclouders pushed a commit that referenced this pull request Oct 13, 2022
@fschade
commit 5eb43fb
722e1f1 
Merge: cc26021 2bc0f71
Author: Florian Schade <f.schade@icloud.com>
Date:   Thu Oct 13 17:56:34 2022 +0200

    Merge pull request #4809 from wkloucek/dont-cache-web-index-html

    don't cache the web index.html
@micbar micbar mentioned this pull request Nov 25, 2022
Closed
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@micbar micbar Awaiting requested review from micbar

@butonic butonic Awaiting requested review from butonic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wkloucek @micbar @fschade @kulmann