Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs-only] Auth basic readme fix env var rename #4981

Merged
merged 3 commits into from
Nov 4, 2022
Merged

[docs-only] Auth basic readme fix env var rename #4981

merged 3 commits into from
Nov 4, 2022

Conversation

butonic
Copy link
Member

@butonic butonic commented Nov 4, 2022 •
edited
Loading

fix leftover from #4966

fixes #4972

@butonic
auth basic readme fix env var rename
6bb2f74 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
update changelog
de098ac 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic butonic self-assigned this Nov 4, 2022
@butonic butonic added the bug label Nov 4, 2022
@butonic butonic added this to the 2.0.0 General Availability milestone Nov 4, 2022
@butonic butonic changed the title Auth basic readme fix env var rename [docs-only] Auth basic readme fix env var rename Nov 4, 2022
@mmattel
Copy link
Contributor

mmattel commented Nov 4, 2022 •
edited
Loading

This also needs a change in the description of the env var:
AUTH_BASIC_AUTH_MANAGER

The authentication provider to check if credentials are valid. Supported value is 'ldap'.
-->
The authentication manager to check if credentials are valid. Supported value is 'ldap'.

@butonic
fix docs
791c2e2 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@sonarcloud
Copy link

sonarcloud bot commented Nov 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mmattel mmattel merged commit 226f39a into master Nov 4, 2022
@delete-merged-branch delete-merged-branch bot deleted the auth_basic_readme_fix_env_var_rename branch November 4, 2022 12:19
ownclouders pushed a commit that referenced this pull request Nov 4, 2022
@mmattel
commit 226f39a
1317890 
Merge: 015743a 791c2e2
Author: Martin <github@diemattels.at>
Date:   Fri Nov 4 13:19:36 2022 +0100

    Merge pull request #4981 from owncloud/auth_basic_readme_fix_env_var_rename

    [docs-only] Auth basic readme fix env var rename
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kobergj kobergj kobergj approved these changes

@mmattel mmattel mmattel approved these changes

@phil-davis phil-davis phil-davis approved these changes

Assignees

@butonic butonic

Labels
None yet
Projects
Infinite Scale Team Board
Archived in project
Milestone
2.0.0 General Availability
Development

Successfully merging this pull request may close these issues.

AUTH_BASIC_AUTH_PROVIDER is misnamed and should be AUTH_BASIC_AUTH_MANAGER
4 participants
@butonic @mmattel @phil-davis @kobergj