Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] add more unit tests for the drives operations #5041

Merged
merged 5 commits into from
Nov 18, 2022
Merged

[tests-only] add more unit tests for the drives operations #5041

merged 5 commits into from
Nov 18, 2022

Conversation

micbar
Copy link
Contributor

@micbar micbar commented Nov 11, 2022 •
edited
Loading

Description

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@micbar micbar mentioned this pull request Nov 11, 2022
Closed
5 tasks
@micbar micbar force-pushed the graph-unit-test branch 2 times, most recently from 44327bd to b252fb0 Compare November 14, 2022 15:12
@micbar micbar marked this pull request as ready for review November 14, 2022 15:12
@micbar micbar force-pushed the graph-unit-test branch 2 times, most recently from 863d513 to 926be6d Compare November 15, 2022 19:43
aduffeck
aduffeck requested changes Nov 16, 2022
View reviewed changes
Copy link
Contributor

@aduffeck aduffeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides the (partly optional) nitpicks.

services/graph/pkg/service/v0/graph.go Outdated Show resolved Hide resolved
services/graph/pkg/service/v0/option.go Show resolved Hide resolved
services/graph/pkg/service/v0/graph.go Show resolved Hide resolved
@micbar micbar requested a review from aduffeck November 16, 2022 20:14
aduffeck
aduffeck approved these changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@aduffeck aduffeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@sonarcloud
Copy link

sonarcloud bot commented Nov 17, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

60.0% 60.0% Coverage
0.0% 0.0% Duplication

@micbar micbar merged commit 1329daf into master Nov 18, 2022
@delete-merged-branch delete-merged-branch bot deleted the graph-unit-test branch November 18, 2022 11:46
ownclouders pushed a commit that referenced this pull request Nov 18, 2022
@micbar
commit 1329daf
b0c0fa0 
Merge: 9504cea d1ff976
Author: Michael Barz <mbarz@owncloud.com>
Date:   Fri Nov 18 12:46:42 2022 +0100

    Merge pull request #5041 from owncloud/graph-unit-test

    [tests-only] add more unit tests for the drives operations
ownclouders pushed a commit that referenced this pull request Nov 21, 2022
@micbar
commit 1329daf
ae231dd 
Merge: 9504cea d1ff976
Author: Michael Barz <mbarz@owncloud.com>
Date:   Fri Nov 18 12:46:42 2022 +0100

    Merge pull request #5041 from owncloud/graph-unit-test

    [tests-only] add more unit tests for the drives operations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduffeck aduffeck aduffeck approved these changes

@butonic butonic Awaiting requested review from butonic

@dragonchaser dragonchaser Awaiting requested review from dragonchaser

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@micbar @aduffeck