Make permission and role ids unique

[butonic]

We've fixed the duplicate assignment of 79e13b30-3e22-11eb-bc51-0b9f0bad9a58 for both: create-space and settings-management permissions. We also deduplicate role ids after listing them internally to make permission retrieval more efficient.

fixes #5033

[update-docs]

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication

[micbar]

@rhafer this may need some upgrade considerations

[rhafer]

@rhafer this may need some upgrade considerations

Yes. We'd need to update the roles that get persisted upon startup of the service accordingly. What makes things even worse is that we're still suffering from: #3432 (which mean the default assignements are duplicated with every restart of ocis 😿 )

[rhafer]

Yes. We'd need to update the roles that get persisted upon startup of the service accordingly. What makes things even worse is that we're still suffering from: #3432 (which mean the default assignements are duplicated with every restart of ocis crying_cat_face )

Hm, thinking again about this, we might actually be lucky. The default roles will be re-created with the new permissions at startup of the settings service. So I think we won't need a migration.

And #3432, while ugly, is unrelated to this.

[rhafer]

I guess this deduplication is mainly needed because of #3432 ?

I am fine merging this. But it seems to paper over a couple of issues:

1. AFAIK for now we wanted to have a restriction so that every user can only have a single role assigned. This does not seem to be enforced anywhere.
2. It is possible to create the same assignment multiple times. The server will happily create that over and over again.