Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test-only] Api-test. assign role to user #5080

Merged
merged 1 commit into from
Nov 23, 2022
Merged

[test-only] Api-test. assign role to user #5080

merged 1 commit into from
Nov 23, 2022

Conversation

ScharfViktor
Copy link
Contributor

@update-docs
Copy link

update-docs bot commented Nov 18, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@SagarGi SagarGi requested a review from saw-jan November 19, 2022 05:34
SagarGi
SagarGi reviewed Nov 22, 2022
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

individual-it
individual-it requested changes Nov 22, 2022
View reviewed changes
Copy link
Member

@individual-it individual-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments, partly the problems have been already in the code before moving it out of the SpaceContext

tests/acceptance/features/bootstrap/RoleAssignmentContext.php Outdated Show resolved Hide resolved
tests/acceptance/features/bootstrap/RoleAssignmentContext.php Outdated Show resolved Hide resolved
tests/acceptance/features/bootstrap/RoleAssignmentContext.php Outdated Show resolved Hide resolved
tests/acceptance/features/bootstrap/RoleAssignmentContext.php Outdated Show resolved Hide resolved
tests/acceptance/features/bootstrap/RoleAssignmentContext.php Outdated Show resolved Hide resolved
tests/acceptance/features/bootstrap/RoleAssignmentContext.php Outdated Show resolved Hide resolved
tests/acceptance/features/bootstrap/RoleAssignmentContext.php Outdated Show resolved Hide resolved
@individual-it individual-it merged commit 0d6a993 into master Nov 23, 2022
@delete-merged-branch delete-merged-branch bot deleted the assignRoleToUser branch November 23, 2022 04:14
ownclouders pushed a commit that referenced this pull request Nov 23, 2022
@individual-it
commit 0d6a993
31b1314 
Merge: 40aaef1 34e4f0f
Author: Artur Neumann <artur@jankaritech.com>
Date:   Wed Nov 23 09:58:59 2022 +0545

    Merge pull request #5080 from owncloud/assignRoleToUser

    [test-only] Api-test. assign role to user
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@individual-it individual-it individual-it approved these changes

@grgprarup grgprarup Awaiting requested review from grgprarup

@saw-jan saw-jan Awaiting requested review from saw-jan

@SagarGi SagarGi Awaiting requested review from SagarGi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ScharfViktor @individual-it @SagarGi @saw-jan