introduce otlp tracing #5132
Merged
introduce otlp tracing #5132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Excds
previously requested changes
May 25, 2023
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
dragonchaser
approved these changes
May 26, 2023
| tp := rtrace.NewTracerProvider( | ||
| rtrace.WithEnabled(), | ||
| rtrace.WithExporter(traceType), | ||
| rtrace.WithInsecure(), |
There was a problem hiding this comment.
Needs fix (later). Secure by default FTW.
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
|
💥 Acceptance test Core-API-Tests-ocis-storage-10 failed. Further test are cancelled... |
|
SonarCloud Quality Gate failed. |
86 tasks
fschade
pushed a commit
that referenced
this pull request
Jul 10, 2023
* introduce otel tracing Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * use new trace provider initialization Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * work * bump reva Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * remove commented code Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * add vendor changes Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> --------- Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was toying with https://github.com/SigNoz/signoz which uses otlp tracing. This PR allows configuring
tracing_exporter=otlpas a trace exporter. It requires cs3org/reva#3496 to make reva use an otlp trace exporter as well.Based on the signoz ui I think we should try to add events to our spans that follow the Trace Semantic Conventions, eg https://opentelemetry.io/docs/reference/specification/trace/semantic_conventions/span-general/ but that is a different PR