Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

walk and log chi routes, ocs cleanup #5428

Merged
merged 2 commits into from
Jan 23, 2023
Merged

walk and log chi routes, ocs cleanup #5428

merged 2 commits into from
Jan 23, 2023

Conversation

butonic
Copy link
Member

@butonic butonic commented Jan 19, 2023

We now log all endpoints handled by the chi router on startup:

$ OCIS_LOG_PRETTY=true ocis/bin/ocis server 2>&1 | grep "serving endpoint"
2023-01-19T11:00:35Z DBG serving endpoint method=GET middlewares=7 route=/config.json service=web
2023-01-19T11:00:35Z DBG serving endpoint method=TRACE middlewares=7 route=/* service=web
2023-01-19T11:00:35Z DBG serving endpoint method=HEAD middlewares=7 route=/* service=web
2023-01-19T11:00:35Z DBG serving endpoint method=OPTIONS middlewares=7 route=/* service=web
2023-01-19T11:00:35Z DBG serving endpoint method=POST middlewares=7 route=/* service=web
2023-01-19T11:00:35Z DBG serving endpoint method=PATCH middlewares=7 route=/* service=web
2023-01-19T11:00:35Z DBG serving endpoint method=CONNECT middlewares=7 route=/* service=web
2023-01-19T11:00:35Z DBG serving endpoint method=PUT middlewares=7 route=/* service=web
2023-01-19T11:00:35Z DBG serving endpoint method=GET middlewares=7 route=/* service=web
2023-01-19T11:00:35Z DBG serving endpoint method=DELETE middlewares=7 route=/* service=web
2023-01-19T11:00:35Z DBG serving endpoint method=GET middlewares=12 route=/ocs/v{version:(1|2)}.php/cloud/user/signing-key service=ocs
2023-01-19T11:00:35Z DBG serving endpoint method=POST middlewares=9 route=/api/v0/settings/assignments-add service=settings
2023-01-19T11:00:35Z DBG serving endpoint method=POST middlewares=9 route=/api/v0/settings/assignments-list service=settings
2023-01-19T11:00:35Z DBG serving endpoint method=POST middlewares=9 route=/api/v0/settings/assignments-remove service=settings
2023-01-19T11:00:35Z DBG serving endpoint method=POST middlewares=9 route=/api/v0/settings/bundle-get service=settings
2023-01-19T11:00:35Z DBG serving endpoint method=POST middlewares=9 route=/api/v0/settings/bundle-save service=settings
2023-01-19T11:00:35Z DBG serving endpoint method=POST middlewares=9 route=/api/v0/settings/bundles-add-setting service=settings
2023-01-19T11:00:35Z DBG serving endpoint method=POST middlewares=9 route=/api/v0/settings/bundles-list service=settings
2023-01-19T11:00:35Z DBG serving endpoint method=POST middlewares=9 route=/api/v0/settings/bundles-remove-setting service=settings
2023-01-19T11:00:35Z DBG serving endpoint method=POST middlewares=9 route=/api/v0/settings/permissions-get-by-id service=settings
2023-01-19T11:00:35Z DBG serving endpoint method=POST middlewares=9 route=/api/v0/settings/permissions-list-by-resource service=settings
2023-01-19T11:00:35Z DBG serving endpoint method=POST middlewares=9 route=/api/v0/settings/roles-list service=settings
2023-01-19T11:00:35Z DBG serving endpoint method=POST middlewares=9 route=/api/v0/settings/values-get service=settings
2023-01-19T11:00:35Z DBG serving endpoint method=POST middlewares=9 route=/api/v0/settings/values-get-by-unique-identifiers service=settings
2023-01-19T11:00:35Z DBG serving endpoint method=POST middlewares=9 route=/api/v0/settings/values-list service=settings
2023-01-19T11:00:35Z DBG serving endpoint method=POST middlewares=9 route=/api/v0/settings/values-save service=settings
2023-01-19T11:00:35Z DBG serving endpoint method=GET middlewares=5 route=/thumbnails/data service=thumbnails
2023-01-19T11:00:35Z DBG serving endpoint method=GET middlewares=8 route=/dav/files/{id} service=webdav
2023-01-19T11:00:35Z DBG serving endpoint method=GET middlewares=8 route=/dav/files/{id}/* service=webdav
2023-01-19T11:00:35Z DBG serving endpoint method=HEAD middlewares=8 route=/dav/public-files/{token}/* service=webdav
2023-01-19T11:00:35Z DBG serving endpoint method=GET middlewares=8 route=/dav/public-files/{token}/* service=webdav
2023-01-19T11:00:35Z DBG serving endpoint method=GET middlewares=8 route=/dav/spaces/{id} service=webdav
2023-01-19T11:00:35Z DBG serving endpoint method=GET middlewares=8 route=/dav/spaces/{id}/* service=webdav
2023-01-19T11:00:35Z DBG serving endpoint method=GET middlewares=8 route=/remote.php/dav/files/{id} service=webdav
2023-01-19T11:00:35Z DBG serving endpoint method=GET middlewares=8 route=/remote.php/dav/files/{id}/* service=webdav
2023-01-19T11:00:35Z DBG serving endpoint method=GET middlewares=8 route=/remote.php/dav/public-files/{token}/* service=webdav
2023-01-19T11:00:35Z DBG serving endpoint method=HEAD middlewares=8 route=/remote.php/dav/public-files/{token}/* service=webdav
2023-01-19T11:00:35Z DBG serving endpoint method=GET middlewares=8 route=/remote.php/dav/spaces/{id} service=webdav
2023-01-19T11:00:35Z DBG serving endpoint method=GET middlewares=8 route=/remote.php/dav/spaces/{id}/* service=webdav
2023-01-19T11:00:35Z DBG serving endpoint method=GET middlewares=8 route=/remote.php/webdav/* service=webdav
2023-01-19T11:00:35Z DBG serving endpoint method=GET middlewares=8 route=/webdav/* service=webdav
2023-01-19T11:00:36Z DBG serving endpoint method=GET middlewares=6 route=/graph/v1.0/applications/ service=graph
2023-01-19T11:00:36Z DBG serving endpoint method=GET middlewares=6 route=/graph/v1.0/applications/{applicationID} service=graph
2023-01-19T11:00:36Z DBG serving endpoint method=GET middlewares=6 route=/graph/v1.0/drives/ service=graph
2023-01-19T11:00:36Z DBG serving endpoint method=POST middlewares=6 route=/graph/v1.0/drives/ service=graph
2023-01-19T11:00:36Z DBG serving endpoint method=DELETE middlewares=6 route=/graph/v1.0/drives/{driveID}/ service=graph
2023-01-19T11:00:36Z DBG serving endpoint method=PATCH middlewares=6 route=/graph/v1.0/drives/{driveID}/ service=graph
2023-01-19T11:00:36Z DBG serving endpoint method=GET middlewares=6 route=/graph/v1.0/drives/{driveID}/ service=graph
2023-01-19T11:00:36Z DBG serving endpoint method=GET middlewares=6 route=/graph/v1.0/education/classes/ service=graph
2023-01-19T11:00:36Z DBG serving endpoint method=POST middlewares=6 route=/graph/v1.0/education/classes/ service=graph
2023-01-19T11:00:36Z DBG serving endpoint method=GET middlewares=6 route=/graph/v1.0/education/classes/{classID}/ service=graph
2023-01-19T11:00:36Z DBG serving endpoint method=DELETE middlewares=6 route=/graph/v1.0/education/classes/{classID}/ service=graph
2023-01-19T11:00:36Z DBG serving endpoint method=PATCH middlewares=6 route=/graph/v1.0/education/classes/{classID}/ service=graph
2023-01-19T11:00:36Z DBG serving endpoint method=GET middlewares=6 route=/graph/v1.0/education/classes/{classID}/members/ service=graph
2023-01-19T11:00:36Z DBG serving endpoint method=POST middlewares=6 route=/graph/v1.0/education/classes/{classID}/members/$ref service=graph
2023-01-19T11:00:36Z DBG serving endpoint method=DELETE middlewares=6 route=/graph/v1.0/education/classes/{classID}/members/{memberID}/$ref service=graph
2023-01-19T11:00:36Z DBG serving endpoint method=GET middlewares=6 route=/graph/v1.0/education/schools/ service=graph
2023-01-19T11:00:36Z DBG serving endpoint method=POST middlewares=6 route=/graph/v1.0/education/schools/ service=graph
2023-01-19T11:00:36Z DBG serving endpoint method=GET middlewares=6 route=/graph/v1.0/education/schools/{schoolID}/ service=graph
2023-01-19T11:00:36Z DBG serving endpoint method=DELETE middlewares=6 route=/graph/v1.0/education/schools/{schoolID}/ service=graph
2023-01-19T11:00:36Z DBG serving endpoint method=PATCH middlewares=6 route=/graph/v1.0/education/schools/{schoolID}/ service=graph
2023-01-19T11:00:36Z DBG serving endpoint method=GET middlewares=6 route=/graph/v1.0/education/schools/{schoolID}/users/ service=graph
2023-01-19T11:00:36Z DBG serving endpoint method=POST middlewares=6 route=/graph/v1.0/education/schools/{schoolID}/users/$ref service=graph
2023-01-19T11:00:36Z DBG serving endpoint method=DELETE middlewares=6 route=/graph/v1.0/education/schools/{schoolID}/users/{userID}/$ref service=graph
2023-01-19T11:00:36Z DBG serving endpoint method=GET middlewares=6 route=/graph/v1.0/education/users/ service=graph
2023-01-19T11:00:36Z DBG serving endpoint method=POST middlewares=6 route=/graph/v1.0/education/users/ service=graph
2023-01-19T11:00:36Z DBG serving endpoint method=GET middlewares=6 route=/graph/v1.0/education/users/{userID}/ service=graph
2023-01-19T11:00:36Z DBG serving endpoint method=DELETE middlewares=6 route=/graph/v1.0/education/users/{userID}/ service=graph
2023-01-19T11:00:36Z DBG serving endpoint method=PATCH middlewares=6 route=/graph/v1.0/education/users/{userID}/ service=graph
2023-01-19T11:00:36Z DBG serving endpoint method=GET middlewares=6 route=/graph/v1.0/extensions/org.libregraph/tags service=graph
2023-01-19T11:00:36Z DBG serving endpoint method=PUT middlewares=6 route=/graph/v1.0/extensions/org.libregraph/tags service=graph
2023-01-19T11:00:36Z DBG serving endpoint method=DELETE middlewares=6 route=/graph/v1.0/extensions/org.libregraph/tags service=graph
2023-01-19T11:00:36Z DBG serving endpoint method=GET middlewares=7 route=/graph/v1.0/groups/ service=graph
2023-01-19T11:00:36Z DBG serving endpoint method=POST middlewares=7 route=/graph/v1.0/groups/ service=graph
2023-01-19T11:00:36Z DBG serving endpoint method=PATCH middlewares=7 route=/graph/v1.0/groups/{groupID}/ service=graph
2023-01-19T11:00:36Z DBG serving endpoint method=GET middlewares=6 route=/graph/v1.0/groups/{groupID}/ service=graph
2023-01-19T11:00:36Z DBG serving endpoint method=DELETE middlewares=7 route=/graph/v1.0/groups/{groupID}/ service=graph
2023-01-19T11:00:36Z DBG serving endpoint method=GET middlewares=7 route=/graph/v1.0/groups/{groupID}/members/ service=graph
2023-01-19T11:00:36Z DBG serving endpoint method=POST middlewares=7 route=/graph/v1.0/groups/{groupID}/members/$ref service=graph
2023-01-19T11:00:36Z DBG serving endpoint method=DELETE middlewares=7 route=/graph/v1.0/groups/{groupID}/members/{memberID}/$ref service=graph
2023-01-19T11:00:36Z DBG serving endpoint method=GET middlewares=6 route=/graph/v1.0/me/ service=graph
2023-01-19T11:00:36Z DBG serving endpoint method=POST middlewares=6 route=/graph/v1.0/me/changePassword service=graph
2023-01-19T11:00:36Z DBG serving endpoint method=GET middlewares=6 route=/graph/v1.0/me/drive/root/children service=graph
2023-01-19T11:00:36Z DBG serving endpoint method=GET middlewares=6 route=/graph/v1.0/me/drives service=graph
2023-01-19T11:00:36Z DBG serving endpoint method=POST middlewares=7 route=/graph/v1.0/users/ service=graph
2023-01-19T11:00:36Z DBG serving endpoint method=GET middlewares=7 route=/graph/v1.0/users/ service=graph
2023-01-19T11:00:36Z DBG serving endpoint method=DELETE middlewares=7 route=/graph/v1.0/users/{userID}/ service=graph
2023-01-19T11:00:36Z DBG serving endpoint method=PATCH middlewares=7 route=/graph/v1.0/users/{userID}/ service=graph
2023-01-19T11:00:36Z DBG serving endpoint method=GET middlewares=6 route=/graph/v1.0/users/{userID}/ service=graph
2023-01-19T11:00:36Z DBG serving endpoint method=GET middlewares=6 route=/graph/v1.0/users/{userID}/appRoleAssignments/ service=graph
2023-01-19T11:00:36Z DBG serving endpoint method=POST middlewares=6 route=/graph/v1.0/users/{userID}/appRoleAssignments/ service=graph
2023-01-19T11:00:36Z DBG serving endpoint method=DELETE middlewares=6 route=/graph/v1.0/users/{userID}/appRoleAssignments/{appRoleAssignmentID} service=graph
2023-01-19T11:00:36Z DBG serving endpoint method=GET middlewares=8 route=/signin/v1/identifier service=idp
2023-01-19T11:00:36Z DBG serving endpoint method=GET middlewares=8 route=/signin/v1/identifier/ service=idp
2023-01-19T11:00:36Z DBG serving endpoint method=GET middlewares=8 route=/signin/v1/identifier/index.html service=idp
2023-01-19T11:00:36Z DBG serving endpoint method=TRACE middlewares=8 route=/* service=idp
2023-01-19T11:00:36Z DBG serving endpoint method=OPTIONS middlewares=8 route=/* service=idp
2023-01-19T11:00:36Z DBG serving endpoint method=PATCH middlewares=8 route=/* service=idp
2023-01-19T11:00:36Z DBG serving endpoint method=PUT middlewares=8 route=/* service=idp
2023-01-19T11:00:36Z DBG serving endpoint method=CONNECT middlewares=8 route=/* service=idp
2023-01-19T11:00:36Z DBG serving endpoint method=HEAD middlewares=8 route=/* service=idp
2023-01-19T11:00:36Z DBG serving endpoint method=DELETE middlewares=8 route=/* service=idp
2023-01-19T11:00:36Z DBG serving endpoint method=GET middlewares=8 route=/* service=idp
2023-01-19T11:00:36Z DBG serving endpoint method=POST middlewares=8 route=/* service=idp

Implementing this I could not resist deleting all the dead code in the ocs service which we only use to get the signing-keys ... so that is why this PR also deletes 649 lines

@update-docs
Copy link

update-docs bot commented Jan 19, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@butonic butonic requested review from C0rby and micbar January 19, 2023 11:06
@butonic butonic marked this pull request as ready for review January 19, 2023 13:25
@ownclouders
Copy link
Contributor

ownclouders commented Jan 19, 2023 •
edited
Loading

💥 Acceptance test Core-API-Tests-ocis-storage-9 failed. Further test are cancelled...

@butonic butonic mentioned this pull request Jan 19, 2023
Merged
@butonic butonic self-assigned this Jan 19, 2023
@fschade
Copy link
Contributor

fschade commented Jan 19, 2023

😮

@butonic
walk and log chi routes, ocs cleanup
f2170b1 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
make linter happy
c1ac3c0 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic butonic force-pushed the graph-walk-chi-routes branch from c8f7919 to c1ac3c0 Compare January 23, 2023 09:55
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

12.5% 12.5% Coverage
0.0% 0.0% Duplication

@butonic butonic merged commit 32cc9be into master Jan 23, 2023
@delete-merged-branch delete-merged-branch bot deleted the graph-walk-chi-routes branch January 23, 2023 11:30
ownclouders pushed a commit that referenced this pull request Jan 23, 2023
@butonic
commit 32cc9be
e0af9c1 
Author: Jörn Friedrich Dreyer <jfd@owncloud.com>
Date:   Mon Jan 23 12:30:34 2023 +0100

    walk and log chi routes, ocs cleanup (#5428)

    * walk and log chi routes, ocs cleanup

    Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

    * make linter happy

    Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

    Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
Copy link
Member Author

butonic commented Feb 23, 2023

This PR actually killed our ocs users endpoint. cdperf k6 can no longer provision users using the ocs/v1.php/cloud/users endpoint.

@butonic butonic mentioned this pull request Feb 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@C0rby C0rby C0rby approved these changes

@micbar micbar Awaiting requested review from micbar

@kulmann kulmann Awaiting requested review from kulmann

@lookacat lookacat Awaiting requested review from lookacat

Assignees

@butonic butonic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@butonic @ownclouders @fschade @C0rby