Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

idp: Utilize ownCloudUserEnabled Attribute to filter users #5620

Merged
merged 2 commits into from
Feb 22, 2023
Merged

idp: Utilize ownCloudUserEnabled Attribute to filter users #5620

merged 2 commits into from
Feb 22, 2023

Conversation

rhafer
Copy link
Contributor

@rhafer rhafer commented Feb 21, 2023

This adds support for configuring an LDAP Attribute that can be used as a flag to disallow users to login. We currently default to 'ownCloudUserEnabled' as used in the default configuration of the graph service.

@rhafer rhafer force-pushed the idp-account-enabled branch from 6f1a210 to de52473 Compare February 21, 2023 15:57
@rhafer rhafer force-pushed the idp-account-enabled branch from de52473 to 8b6d1ce Compare February 21, 2023 15:59
@rhafer rhafer mentioned this pull request Feb 21, 2023
Closed
@mmattel
Copy link
Contributor

mmattel commented Feb 21, 2023

We should add some text to the readme with regards to LDAP_USER_ENABLED_ATTRIBUTE.
Currently we have more text in the ocis admin doku for idm than here in the readme. I would propose the following: add a section with in the readme Configuration Hints same as we have in the admin docs and add a description about the new attribute. After merging, I will complete the text here with the missing stuff in a new PR and transport the changes of the attribute description to the ocis admin docs.

@rhafer
Copy link
Contributor Author

rhafer commented Feb 22, 2023

Currently we have more text in the ocis admin doku for idm than here in the readme.

This pull request is for the IDP service, not IDM. 🙂

IDP has no README at all currently. I will create a separate PR for that.

@rhafer
idp: Utilize ownCloudUserEnabled Attribute to filter users
bc494da 
This adds support for configuring an LDAP Attribute that can be used as a flag
to disallow users to login. We currently default to 'ownCloudUserEnabled' as
used in the default configuration of the graph service.
@rhafer rhafer force-pushed the idp-account-enabled branch from 8b6d1ce to bc494da Compare February 22, 2023 08:42
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@rhafer
Copy link
Contributor Author

rhafer commented Feb 22, 2023

Currently we have more text in the ocis admin doku for idm than here in the readme.

This pull request is for the IDP service, not IDM. 🙂

IDP has no README at all currently. I will create a separate PR for that.

@rhafer rhafer closed this Feb 22, 2023
@rhafer rhafer reopened this Feb 22, 2023
@rhafer rhafer requested review from ainmosni, C0rby and kobergj February 22, 2023 09:49
@Excds Excds self-assigned this Feb 22, 2023
Excds
Excds approved these changes Feb 22, 2023
View reviewed changes
Copy link

@Excds Excds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhafer rhafer merged commit 9e73b17 into owncloud:master Feb 22, 2023
@micbar micbar mentioned this pull request May 3, 2023
Closed
89 tasks
@ScharfViktor ScharfViktor mentioned this pull request May 4, 2023
Closed
86 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmattel mmattel mmattel left review comments

@Excds Excds Excds approved these changes

@ainmosni ainmosni Awaiting requested review from ainmosni

@C0rby C0rby Awaiting requested review from C0rby

@kobergj kobergj Awaiting requested review from kobergj

Assignees

@Excds Excds

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rhafer @mmattel @Excds