Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent duplicate accounts #587

Closed
wants to merge 3 commits into from
Closed

Prevent duplicate accounts #587

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4aa6e6c
Changelog
kulmann Sep 16, 2020
0ec3cd7
update ocis-accounts@master
kulmann Sep 16, 2020
ddd297b
Remove suceeding test from expected failures lists
kulmann Sep 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions changelog/unreleased/update-accounts-prevent-duplicate-users.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Bugfix: Don't create account if id/mail/username already taken

We don't allow anymore to create a new account if the provided id/mail/username is already taken.

https://github.com/owncloud/ocis-accounts/pull/123
https://github.com/owncloud/ocis/pull/587
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ require (
github.com/micro/micro/v2 v2.8.0
github.com/openzipkin/zipkin-go v0.2.2
github.com/owncloud/flaex v0.2.0
github.com/owncloud/ocis-accounts v0.4.2-0.20200911161616-e55b8ae2f440
github.com/owncloud/ocis-accounts v0.4.2-0.20200916100224-0d0a07e80f7a
github.com/owncloud/ocis-glauth v0.5.1-0.20200909064150-0735ec933777
github.com/owncloud/ocis-graph v0.0.0-20200318175820-9a5a6e029db7
github.com/owncloud/ocis-graph-explorer v0.0.0-20200210111049-017eeb40dc0c
Expand Down
4 changes: 4 additions & 0 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,7 @@ github.com/aws/aws-sdk-go v1.33.19 h1:SMna0QLInNqm+nNL9tb7OVWTqSfNYSxrCa2adnyVth
github.com/aws/aws-sdk-go v1.33.19/go.mod h1:5zCpMtNQVjRREroY7sYe8lOMRSxkhG6MZveU8YkpAk0=
github.com/aws/aws-sdk-go v1.34.2 h1:9vCknCdTAmmV4ht7lPuda7aJXzllXwEQyCMZKJHjBrM=
github.com/aws/aws-sdk-go v1.34.2/go.mod h1:5zCpMtNQVjRREroY7sYe8lOMRSxkhG6MZveU8YkpAk0=
github.com/aws/aws-sdk-go v1.34.12 h1:7UbBEYDUa4uW0YmRnOd806MS1yoJMcaodBWDzvBShAI=
github.com/aws/aws-sdk-go v1.34.12/go.mod h1:5zCpMtNQVjRREroY7sYe8lOMRSxkhG6MZveU8YkpAk0=
github.com/aws/aws-xray-sdk-go v0.9.4/go.mod h1:XtMKdBQfpVut+tJEwI7+dJFRxxRdxHDyVNp2tHXRq04=
github.com/baiyubin/aliyun-sts-go-sdk v0.0.0-20180326062324-cfa1a18b161f/go.mod h1:AuiFmCCPBSrqvVMvuqFuk0qogytodnVFVSN5CeJB8Gc=
Expand Down Expand Up @@ -324,6 +325,7 @@ github.com/cs3org/reva v1.1.1-0.20200819100654-dcbf0c8ea187 h1:ZyDXH+zy5KPOH5AM5
github.com/cs3org/reva v1.1.1-0.20200819100654-dcbf0c8ea187/go.mod h1:gkGtoun9QABW8k7jzAWWxB9jO64DJ1lreSzTucci/ok=
github.com/cs3org/reva v1.2.1-0.20200826162318-c0f54e1f37ea h1:xVyJvR+GoaBrRJV6GnDflgm9bzkmjchCBBg0nMiHu6M=
github.com/cs3org/reva v1.2.1-0.20200826162318-c0f54e1f37ea/go.mod h1:FvYB+UPpuPCw0hH42qHVR1R2atZyy69METZI/zEaST8=
github.com/cs3org/reva v1.2.1-0.20200911111727-51649e37df2d h1:vohUfrOZVrbbzt7JUICBDX8rjcedLbuEsmuOJtx8mWY=
github.com/cs3org/reva v1.2.1-0.20200911111727-51649e37df2d/go.mod h1:Q1/JB40ZKtlhZUxz+ZqB/O/VlrnQX//NYdPPRPsP0UE=
github.com/cznic/b v0.0.0-20181122101859-a26611c4d92d h1:SwD98825d6bdB+pEuTxWOXiSjBrHdOl/UVp75eI7JT8=
github.com/cznic/b v0.0.0-20181122101859-a26611c4d92d/go.mod h1:URriBxXwVq5ijiJ12C7iIZqlA69nTlI+LgI6/pwftG8=
Expand Down Expand Up @@ -1271,6 +1273,8 @@ github.com/owncloud/ocis-accounts v0.4.2-0.20200911145524-bf3fb9eb4be6 h1:4e4u6u
github.com/owncloud/ocis-accounts v0.4.2-0.20200911145524-bf3fb9eb4be6/go.mod h1:wNACZ+jUb1upH9Uy74+rmGW5ZF4Y3/PBRHDuEfxQrYc=
github.com/owncloud/ocis-accounts v0.4.2-0.20200911161616-e55b8ae2f440 h1:NOt2IoHWGG+gRkNGmEfU/Y8GxWH256hF5KzS21srEto=
github.com/owncloud/ocis-accounts v0.4.2-0.20200911161616-e55b8ae2f440/go.mod h1:wNACZ+jUb1upH9Uy74+rmGW5ZF4Y3/PBRHDuEfxQrYc=
github.com/owncloud/ocis-accounts v0.4.2-0.20200916100224-0d0a07e80f7a h1:hoDwVsFV0B3R+CQxsNu23nUQqU36cPaRFVgrIuI41ok=
github.com/owncloud/ocis-accounts v0.4.2-0.20200916100224-0d0a07e80f7a/go.mod h1:wNACZ+jUb1upH9Uy74+rmGW5ZF4Y3/PBRHDuEfxQrYc=
github.com/owncloud/ocis-glauth v0.5.1-0.20200731165959-1081de7c60f1 h1:YA7tS4VFSUmjeZBt4Wa+fSoreH1VJYCFlHvoRey3ngM=
github.com/owncloud/ocis-glauth v0.5.1-0.20200731165959-1081de7c60f1/go.mod h1:lZkoEjBuEi0QZUlBG+XgVvWC4GzbWCTnmZQcIhC2kMg=
github.com/owncloud/ocis-glauth v0.5.1-0.20200909064150-0735ec933777 h1:WqILokqgQ1M8Iau8o27zr4BV5IWgTzgLlNYGmIkOgJ4=
Expand Down
2 changes: 0 additions & 2 deletions tests/acceptance/expected-failures-on-OCIS-storage.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,15 +157,13 @@ apiProvisioning-v1/resetUserPassword.feature:21
apiProvisioning-v1/resetUserPassword.feature:55
apiProvisioning-v2/addUser.feature:29
apiProvisioning-v2/addUser.feature:30
apiProvisioning-v2/addUser.feature:32
apiProvisioning-v2/addUser.feature:39
apiProvisioning-v2/addUser.feature:69
apiProvisioning-v2/addUser.feature:96
apiProvisioning-v2/addUser.feature:97
apiProvisioning-v2/addUser.feature:98
apiProvisioning-v2/addUser.feature:99
apiProvisioning-v2/addUser.feature:100
apiProvisioning-v2/addUser.feature:102
apiProvisioning-v2/apiProvisioningUsingAppPassword.feature:39
apiProvisioning-v2/apiProvisioningUsingAppPassword.feature:67
apiProvisioning-v2/deleteUser.feature:29
Expand Down
2 changes: 0 additions & 2 deletions tests/acceptance/expected-failures-on-OWNCLOUD-storage.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,15 +157,13 @@ apiProvisioning-v1/resetUserPassword.feature:21
apiProvisioning-v1/resetUserPassword.feature:55
apiProvisioning-v2/addUser.feature:29
apiProvisioning-v2/addUser.feature:30
apiProvisioning-v2/addUser.feature:32
apiProvisioning-v2/addUser.feature:39
apiProvisioning-v2/addUser.feature:69
apiProvisioning-v2/addUser.feature:96
apiProvisioning-v2/addUser.feature:97
apiProvisioning-v2/addUser.feature:98
apiProvisioning-v2/addUser.feature:99
apiProvisioning-v2/addUser.feature:100
apiProvisioning-v2/addUser.feature:102
apiProvisioning-v2/apiProvisioningUsingAppPassword.feature:39
apiProvisioning-v2/apiProvisioningUsingAppPassword.feature:67
apiProvisioning-v2/deleteUser.feature:29
Expand Down