Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

graph: Allow updating of group name via PATCH request #5949

Merged
merged 3 commits into from
Mar 29, 2023
Merged

graph: Allow updating of group name via PATCH request #5949

merged 3 commits into from
Mar 29, 2023

Conversation

Excds
Copy link

@Excds Excds commented Mar 28, 2023

Description

Modifying group PATCH to allow modifying of group name

Related Issue

How Has This Been Tested?

Added unit tests and tested with curl.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@Excds Excds added the Status:Needs-Review Needs review from a maintainer label Mar 28, 2023
@Excds Excds requested review from rhafer and ainmosni March 28, 2023 11:11
@Excds Excds self-assigned this Mar 28, 2023
@update-docs
Copy link

update-docs bot commented Mar 28, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ownclouders
Copy link
Contributor

💥 Acceptance test localApiTests-apiGraph-ocis failed. Further test are cancelled...

@micbar
Copy link
Contributor

micbar commented Mar 28, 2023

@Excds

You made the following tests pass:

apiGraph/editGroup.feature:20
apiGraph/editGroup.feature:21
apiGraph/editGroup.feature:22
apiGraph/editGroup.feature:24
apiGraph/editGroup.feature:40

That means, there is good stuff in the PR 😄

dragonchaser
dragonchaser approved these changes Mar 28, 2023
View reviewed changes
Copy link
Member

@dragonchaser dragonchaser left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ignore this one, hit the wrong combo box :/

dragonchaser
dragonchaser requested changes Mar 28, 2023
View reviewed changes
Copy link
Member

@dragonchaser dragonchaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, though it seems to break other tests in the ci

kobergj
kobergj approved these changes Mar 28, 2023
View reviewed changes
Copy link
Collaborator

@kobergj kobergj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Just remove passing tests from expected failures

@micbar
Copy link
Contributor

micbar commented Mar 29, 2023

please add a changelog

@sonarcloud
Copy link

sonarcloud bot commented Mar 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

69.2% 69.2% Coverage
0.0% 0.0% Duplication

@Excds Excds merged commit 053ce7a into master Mar 29, 2023
@delete-merged-branch delete-merged-branch bot deleted the excds/feature/Update_group_names branch March 29, 2023 10:48
ownclouders pushed a commit that referenced this pull request Mar 29, 2023
Merge pull request #5949 from owncloud/excds/feature/Update_group_names
db5e004 
graph: Allow updating of group name via PATCH request
@micbar micbar mentioned this pull request May 3, 2023
Closed
89 tasks
@ScharfViktor ScharfViktor mentioned this pull request May 4, 2023
Closed
86 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kobergj kobergj kobergj approved these changes

@dragonchaser dragonchaser dragonchaser approved these changes

@rhafer rhafer Awaiting requested review from rhafer

@ainmosni ainmosni Awaiting requested review from ainmosni

Assignees

@Excds Excds

Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ocis] Rename groups
5 participants
@Excds @ownclouders @micbar @dragonchaser @kobergj