Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDPR Export #5950

Merged
merged 9 commits into from
Mar 30, 2023
Merged

GDPR Export #5950

merged 9 commits into from
Mar 30, 2023

Conversation

kobergj
Copy link
Collaborator

@kobergj kobergj commented Mar 28, 2023

Adds an endpoint to get all data related to a user

Signed-off-by: jkoberg <jkoberg@owncloud.com>
Signed-off-by: jkoberg <jkoberg@owncloud.com>
Signed-off-by: jkoberg <jkoberg@owncloud.com>
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@kobergj kobergj force-pushed the GDPRExport branch 3 times, most recently from 7d7d045 to 21df11c Compare March 29, 2023 14:12
Signed-off-by: jkoberg <jkoberg@owncloud.com>
Signed-off-by: jkoberg <jkoberg@owncloud.com>
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@kobergj kobergj marked this pull request as ready for review March 30, 2023 09:26

func touchFile(ctx context.Context, ref *provider.Reference, gwc gateway.GatewayAPIClient) error {
resp, err := gwc.TouchFile(ctx, &provider.TouchFileRequest{
Opaque: utils.AppendPlainToOpaque(nil, "markprocessing", "true"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume the reva update is already part of that PR

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Already part of this PR

@micbar
Copy link
Contributor

micbar commented Mar 30, 2023

Looks good in general.

open items:

  • Add Request to the libregraph spec

Copy link
Contributor

@ainmosni ainmosni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just found a small typo.

services/graph/pkg/service/v0/personaldata.go Outdated Show resolved Hide resolved
services/graph/pkg/service/v0/personaldata.go Outdated Show resolved Hide resolved
services/graph/pkg/service/v0/personaldata.go Outdated Show resolved Hide resolved
Copy link
Contributor

@ainmosni ainmosni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just found a small typo.

Co-authored-by: Daniël Franke <df@ponc.tech>
@kobergj
Copy link
Collaborator Author

kobergj commented Mar 30, 2023

Libregraph PR: owncloud/libre-graph-api#101

@kobergj kobergj requested review from ainmosni and micbar March 30, 2023 12:56
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@sonarcloud
Copy link

sonarcloud bot commented Mar 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.9% 0.9% Coverage
0.0% 0.0% Duplication

@micbar micbar dismissed ainmosni’s stale review March 30, 2023 14:48

Review was addressed

@kobergj kobergj merged commit 3a8b404 into owncloud:master Mar 30, 2023
@kobergj kobergj deleted the GDPRExport branch March 30, 2023 14:56
ownclouders pushed a commit that referenced this pull request Mar 30, 2023
ownclouders pushed a commit that referenced this pull request Mar 30, 2023
@micbar micbar mentioned this pull request May 3, 2023
89 tasks
@ScharfViktor ScharfViktor mentioned this pull request May 4, 2023
86 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants