fix the wrong status code when appRoleAssignments is forbidden #6037

[2403905]

fix the wrong status code when appRoleAssignments is forbidden #6037 #6035

Description

Fix the wrong status code when appRoleAssignments is forbidden in the CreateAppRoleAssignment and DeleteAppRoleAssignment methods.

Related Issue

• Fixes <issue_link>

How Has This Been Tested?

• test environment: local
• test case 1:

curl -kv -XPOST -u test1:test1 https://localhost:9200/graph/v1.0/users/df1105a3-1f5c-44e4-a1c4-a253f69faa89/appRoleAssignments \
-H 'Content-Type: application/json' \
-d '{"appRoleId":"2aadd357-682c-406b-8874-293091995fdd","resourceId":"application-1","principalId":"df1105a3-1f5c-44e4-a1c4-a253f69faa89"}'

{"error":{"code":"generalException","innererror":{"date":"2023-05-10T16:21:51Z","request-id":"Julias-MacBook-Pro.local/Bojl5NKzIT-000834"},"message":"{\"id\":\"ocis-settings\",\"code\":403,\"detail\":\"Changing own role assignment forbidden\",\"status\":\"Forbidden\"}"}}

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:

[update-docs]

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication