Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the default roles #6310

Merged
merged 2 commits into from
May 16, 2023
Merged

update the default roles #6310

merged 2 commits into from
May 16, 2023

Conversation

micbar
Copy link
Contributor

@micbar micbar commented May 15, 2023

Description

Bugfix: Update the default admin role

The admin role was missing two permissions. We added them to make the space admin role a subset of the admin role. This matches better with the default user expectations.

#6310

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@micbar
Copy link
Contributor Author

micbar commented May 15, 2023

@mmattel this changes the default roles

@ownclouders
Copy link
Contributor

💥 Acceptance test localApiTests-apiSpaces-ocis failed. Further test are cancelled...

@micbar
Copy link
Contributor Author

micbar commented May 16, 2023

@ScharfViktor @amrita-shrestha This already fixes it on the API level.

@sonarcloud
Copy link

sonarcloud bot commented May 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@micbar micbar merged commit d4e7034 into master May 16, 2023
ownclouders pushed a commit that referenced this pull request May 16, 2023
@micbar micbar deleted the update-roles branch June 20, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants