-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add glauth fallback backend #649
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
butonic
force-pushed
the
glauth-fallback-backend
branch
from
October 5, 2020 21:14
5af59ef
to
0fc99f1
Compare
butonic
force-pushed
the
glauth-fallback-backend
branch
from
October 5, 2020 21:16
0fc99f1
to
0303fe2
Compare
micbar
reviewed
Oct 5, 2020
butonic
force-pushed
the
glauth-fallback-backend
branch
4 times, most recently
from
October 6, 2020 11:43
dfbdf18
to
2787f06
Compare
felixboehm
approved these changes
Oct 6, 2020
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
butonic
force-pushed
the
glauth-fallback-backend
branch
from
October 6, 2020 14:39
2787f06
to
cbbfeec
Compare
kulmann
reviewed
Oct 8, 2020
Co-authored-by: Benedikt Kulmann <benedikt@kulmann.biz>
micbar
approved these changes
Oct 8, 2020
kulmann
approved these changes
Oct 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good (didn't run it)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We introduced the
fallback-datastore
config option and the corresponding options to allow configuring a simple chain of two handlers.Simple, because it is intended for bind and single result search queries. Merging large sets of results is currently out of scope. For now, the implementation will only search the fallback backend if the default backend returns an error or the number of results is 0. This is sufficient to allow an IdP to authenticate users from ocis as well as owncloud 10 as described in the bridge scenario.
fixes owncloud/ocis-glauth#18