Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add glauth fallback backend #649

Merged
merged 3 commits into from
Oct 8, 2020
Merged

Conversation

butonic
Copy link
Member

@butonic butonic commented Oct 5, 2020

We introduced the fallback-datastore config option and the corresponding options to allow configuring a simple chain of two handlers.

Simple, because it is intended for bind and single result search queries. Merging large sets of results is currently out of scope. For now, the implementation will only search the fallback backend if the default backend returns an error or the number of results is 0. This is sufficient to allow an IdP to authenticate users from ocis as well as owncloud 10 as described in the bridge scenario.

  • changelog
  • fix search when fallback backend is enabled

fixes owncloud/ocis-glauth#18

@update-docs
Copy link

update-docs bot commented Oct 5, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@butonic butonic changed the title [WIP] add glauth fallback backend add glauth fallback backend Oct 5, 2020
@butonic butonic self-assigned this Oct 5, 2020
@butonic butonic requested a review from pmaier1 October 5, 2020 21:15
@butonic butonic added the bug label Oct 5, 2020
ocis/go.mod Outdated Show resolved Hide resolved
@butonic butonic force-pushed the glauth-fallback-backend branch 4 times, most recently from dfbdf18 to 2787f06 Compare October 6, 2020 11:43
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Co-authored-by: Benedikt Kulmann <benedikt@kulmann.biz>
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good (didn't run it)

@micbar micbar merged commit f9e1b7b into owncloud:master Oct 8, 2020
ownclouders pushed a commit that referenced this pull request Oct 8, 2020
Merge: 4b9215b 3086102
Author: Michael Barz <mbarz@owncloud.com>
Date:   Thu Oct 8 13:16:22 2020 +0200

    Merge pull request #649 from butonic/glauth-fallback-backend

    add glauth fallback backend
@butonic butonic deleted the glauth-fallback-backend branch June 8, 2022 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ocis-glauth won't start with GLAUTH_BACKEND_DATASTORE=owncloud
4 participants