Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci]Add tests for checking response of REPORT request in project spaces #6622

Merged
merged 3 commits into from
Jun 27, 2023
Merged

[tests-only][full-ci]Add tests for checking response of REPORT request in project spaces #6622

merged 3 commits into from
Jun 27, 2023

Conversation

SwikritiT
Copy link
Contributor

Backport: #6609

@SwikritiT SwikritiT self-assigned this Jun 26, 2023
@SwikritiT SwikritiT force-pushed the backport/tests/add-report-req-permission-project-spaces branch from 9b28ae8 to 080126c Compare June 26, 2023 09:55
@SwikritiT SwikritiT mentioned this pull request Jun 26, 2023
Closed
@SwikritiT
Copy link
Contributor Author

SwikritiT commented Jun 27, 2023 •
edited
Loading

@phil-davis I have removed the skip tag and then removed the permission check for the stable-3.0 branch. Is that okay to do? I think this branch also needs coverage for the other field check

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis
Copy link
Contributor

Yes, that is fine, if it is OK that the scenarios will be 1-line different in stable compared to master.

@SwikritiT SwikritiT merged commit a741d21 into stable-3.0 Jun 27, 2023
@delete-merged-branch delete-merged-branch bot deleted the backport/tests/add-report-req-permission-project-spaces branch June 27, 2023 07:22
ownclouders pushed a commit that referenced this pull request Jun 27, 2023
@SwikritiT
[tests-only][full-ci]Add tests for checking response of REPORT reques…
0af036b 
…t in project spaces (#6622)

* Add tests for checking response of REPORT request in project spaces

* add skip tag

* remove permission check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@saw-jan saw-jan saw-jan approved these changes

@grgprarup grgprarup Awaiting requested review from grgprarup

@SagarGi SagarGi Awaiting requested review from SagarGi

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@ScharfViktor ScharfViktor Awaiting requested review from ScharfViktor

Assignees

@SwikritiT SwikritiT

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SwikritiT @phil-davis @SagarGi @saw-jan @amrita-shrestha