Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] added test for mail notification in different languages when shared to group #6655

Merged
merged 1 commit into from
Jun 30, 2023
Merged

[tests-only][full-ci] added test for mail notification in different languages when shared to group #6655

merged 1 commit into from
Jun 30, 2023

Conversation

nirajacharya2
Copy link
Contributor

@nirajacharya2 nirajacharya2 commented Jun 28, 2023 •
edited
Loading

Description

This PR adds the API test scenario for mail notification.

  • Scenario: group members get an email notification in their respective languages when someone shares a folder with the group
  • Scenario: group members get an email notification in their respective languages when someone shares a file with the group
  • Scenario: group members get an email notification in their respective languages when someone shares a space with the group

Related Issue

Motivation and Context

How Has This Been Tested?

test environment:

  • locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@nirajacharya2 nirajacharya2 self-assigned this Jun 28, 2023
@nirajacharya2 nirajacharya2 mentioned this pull request Jun 28, 2023
Closed
51 tasks
@nirajacharya2 nirajacharya2 force-pushed the mail-translation-notification-group branch from 8bd2133 to 540bc63 Compare June 28, 2023 11:28
@nirajacharya2 nirajacharya2 force-pushed the mail-translation-notification-group branch from 540bc63 to e3c73d5 Compare June 28, 2023 11:29
saw-jan
saw-jan approved these changes Jun 28, 2023
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

SwikritiT
SwikritiT approved these changes Jun 29, 2023
View reviewed changes
Copy link
Contributor

@SwikritiT SwikritiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SagarGi
SagarGi reviewed Jun 29, 2023
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@nirajacharya2 nirajacharya2 force-pushed the mail-translation-notification-group branch from e3c73d5 to 7a9279c Compare June 29, 2023 04:25
@sonarcloud
Copy link

sonarcloud bot commented Jun 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

saw-jan
saw-jan approved these changes Jun 29, 2023
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But please state that you have added new scenarios or made new changes while re-requesting review because a new scenario was added after the PR was already approved.

@nirajacharya2
Copy link
Contributor Author

nirajacharya2 commented Jun 29, 2023 •
edited
Loading

@SagarGi @SwikritiT i added a new scenario to this PR please re-review it

SagarGi
SagarGi reviewed Jun 30, 2023
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@saw-jan saw-jan merged commit 53fb179 into stable-3.0 Jun 30, 2023
@delete-merged-branch delete-merged-branch bot deleted the mail-translation-notification-group branch June 30, 2023 06:41
ownclouders pushed a commit that referenced this pull request Jun 30, 2023
@nirajacharya2
added test for mail notification in diffrent languages when sharing r…
d6ef0bc 
…esources (#6655)
ownclouders pushed a commit that referenced this pull request Jul 2, 2023
@nirajacharya2
added test for mail notification in diffrent languages when sharing r…
6370758 
…esources (#6655)
ownclouders pushed a commit that referenced this pull request Jul 3, 2023
@nirajacharya2
added test for mail notification in diffrent languages when sharing r…
4972c1e 
…esources (#6655)
@phil-davis phil-davis changed the title [tests-only][full-ci] added test for mail notification in diffrent languages when shared to group [tests-only][full-ci] added test for mail notification in different languages when shared to group Jul 3, 2023
@saw-jan saw-jan mentioned this pull request Jul 3, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SagarGi SagarGi SagarGi left review comments

@SwikritiT SwikritiT SwikritiT approved these changes

@saw-jan saw-jan saw-jan approved these changes

@grgprarup grgprarup Awaiting requested review from grgprarup

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

Assignees

@nirajacharya2 nirajacharya2

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nirajacharya2 @SwikritiT @SagarGi @saw-jan