Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci]Search files through content by sharee #6698

Merged
merged 1 commit into from
Jul 20, 2023
Merged

[tests-only][full-ci]Search files through content by sharee #6698

merged 1 commit into from
Jul 20, 2023

Conversation

nabim777
Copy link
Member

@nabim777 nabim777 commented Jul 3, 2023 •
edited by SwikritiT
Loading

Description

This PR adds the API tests for full search api. The scenarios added in this PR are

Related Issue

Motivation and Context

  • there was no test coverage for api test for sharee search files using content. so, this PR covers the require scenario test case

How Has This Been Tested?

  • test environment:
  • locally
  • CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@nabim777 nabim777 self-assigned this Jul 3, 2023
@nabim777 nabim777 changed the title [tests-only][full-ci]Search files threw context by sharee [tests-only][full-ci]Search files through context by sharee Jul 4, 2023
@nabim777 nabim777 mentioned this pull request Jul 4, 2023
Closed
51 tasks
@nabim777 nabim777 force-pushed the search-files-threw-context-by-sharee branch 5 times, most recently from b92ebee to 7e0cb29 Compare July 18, 2023 04:59
@nabim777 nabim777 marked this pull request as ready for review July 18, 2023 04:59
@saw-jan
Copy link
Member

saw-jan commented Jul 18, 2023

@nabim777 update the PR title and the description. (should be content)

@nabim777 nabim777 changed the title [tests-only][full-ci]Search files through context by sharee [tests-only][full-ci]Search files through content by sharee Jul 18, 2023
@nabim777 nabim777 force-pushed the search-files-threw-context-by-sharee branch from 7e0cb29 to 6997e19 Compare July 19, 2023 05:00
@nabim777 nabim777 requested a review from grgprarup July 19, 2023 05:01
@sonarcloud
Copy link

sonarcloud bot commented Jul 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

saw-jan
saw-jan reviewed Jul 19, 2023
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SagarGi
SagarGi reviewed Jul 20, 2023
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

phil-davis
phil-davis approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nabim777 nabim777 merged commit e71b72c into master Jul 20, 2023
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the search-files-threw-context-by-sharee branch July 20, 2023 06:05
ownclouders pushed a commit that referenced this pull request Jul 20, 2023
@nabim777
add test for search files by sharee using content (#6698)
268fe1e
@nabim777 nabim777 mentioned this pull request Jul 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SagarGi SagarGi SagarGi left review comments

@saw-jan saw-jan saw-jan left review comments

@phil-davis phil-davis phil-davis approved these changes

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

@Salipa-Gurung Salipa-Gurung Awaiting requested review from Salipa-Gurung

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

@grgprarup grgprarup Awaiting requested review from grgprarup

@ScharfViktor ScharfViktor Awaiting requested review from ScharfViktor

Assignees

@nabim777 nabim777

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nabim777 @saw-jan @phil-davis @grgprarup @SagarGi