Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add request id to all responses #6715

Merged
merged 1 commit into from
Jul 10, 2023
Merged

add request id to all responses #6715

merged 1 commit into from
Jul 10, 2023

Conversation

micbar
Copy link
Contributor

@micbar micbar commented Jul 4, 2023

Description

add X-Request-ID to all responses.

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Jul 4, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@micbar micbar requested review from butonic, rhafer and JammingBen July 4, 2023 15:09
@micbar micbar force-pushed the requestID-response branch from 6986cc4 to f5bcc0a Compare July 4, 2023 15:10
JammingBen
JammingBen approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm! :)

rhafer
rhafer approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@rhafer rhafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mmattel
Copy link
Contributor

mmattel commented Jul 7, 2023

Wouldn't it be beneficial to have that documented in the dev docs?

@micbar
add request id to all responses
dce3a62 
Signed-off-by: Michael Barz <mbarz@owncloud.com>
@micbar micbar force-pushed the requestID-response branch from f5bcc0a to dce3a62 Compare July 10, 2023 08:56
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@micbar micbar merged commit ecfe2d9 into master Jul 10, 2023
@delete-merged-branch delete-merged-branch bot deleted the requestID-response branch July 10, 2023 14:25
ownclouders pushed a commit that referenced this pull request Jul 10, 2023
@micbar
Merge pull request #6715 from owncloud/requestID-response
e29fb7d 
add request id to all responses
@ScharfViktor ScharfViktor mentioned this pull request Jul 10, 2023
Merged
@micbar micbar mentioned this pull request Jul 24, 2023
Closed
68 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JammingBen JammingBen JammingBen approved these changes

@rhafer rhafer rhafer approved these changes

@butonic butonic Awaiting requested review from butonic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Always display requestID when something fails
4 participants
@micbar @mmattel @rhafer @JammingBen