Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[api-test][full-ci]ApiTest. moving fullSearch to another suite #6716

Closed
wants to merge 2 commits into from
Closed

[api-test][full-ci]ApiTest. moving fullSearch to another suite #6716

wants to merge 2 commits into from

Conversation

ScharfViktor
Copy link
Contributor

@ScharfViktor ScharfViktor commented Jul 4, 2023 •
edited by saw-jan
Loading

moving fullSearch.feature and enforcePublicLink.feature from apiGraph to another suite. #6641

@update-docs
Copy link

update-docs bot commented Jul 4, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ScharfViktor ScharfViktor mentioned this pull request Jul 4, 2023
Merged
10 tasks
saw-jan
saw-jan reviewed Jul 5, 2023
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we have to think about organizing features from apiSpaces and apiSpacesShares because they both have the longest ci runtime (among local oCIS tests).

@ScharfViktor
Copy link
Contributor Author

LGTM, but we have to think about organizing features from apiSpaces and apiSpacesShares because they both have the longest ci runtime (among local oCIS tests).

yes, true. marked myself, I'll do it later.

@ScharfViktor ScharfViktor changed the title [api-test]ApiTest. moving fullSearch to another suite [api-test][full-ci]ApiTest. moving fullSearch to another suite Jul 19, 2023
@ScharfViktor ScharfViktor changed the title [api-test][full-ci]ApiTest. moving fullSearch to another suite [api-test]ApiTest. moving fullSearch to another suite Jul 19, 2023
@ScharfViktor ScharfViktor changed the title [api-test]ApiTest. moving fullSearch to another suite [api-test][full-ci]ApiTest. moving fullSearch to another suite Jul 19, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@saw-jan
Copy link
Member

saw-jan commented Jul 19, 2023

Looks like, need to update the behat.yml file as well for the transfered test suites
https://drone.owncloud.com/owncloud/ocis/24589/52/5

saw-jan
saw-jan requested changes Sep 7, 2023
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ScharfViktor fullSearch.feature is now moved to its own suite (apiSearch). So now, you can only move enforcePasswordLink.feature in this PR.

@sonarcloud
Copy link

sonarcloud bot commented Sep 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ScharfViktor ScharfViktor deleted the moveFullSearchToAnotherSuite branch April 17, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nabim777 nabim777 Awaiting requested review from nabim777

@saw-jan saw-jan Awaiting requested review from saw-jan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ScharfViktor @saw-jan