Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci]add scenario for search folder tag #6725

Merged
merged 1 commit into from
Jul 11, 2023
Merged

[tests-only][full-ci]add scenario for search folder tag #6725

merged 1 commit into from
Jul 11, 2023

Conversation

nabim777
Copy link
Member

@nabim777 nabim777 commented Jul 5, 2023 •
edited
Loading

Description

This PR adds the API tests for full search api. The scenarios added in this PR are

Related Issue

Motivation and Context

  • there was no test coverage for api test for search folder using tag. so, this PR covers the require scenario test case

How Has This Been Tested?

  • test environment:
  • locally
  • CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@nabim777 nabim777 self-assigned this Jul 5, 2023
@nabim777 nabim777 mentioned this pull request Jul 5, 2023
Closed
51 tasks
@nabim777 nabim777 force-pushed the search-folder-tag branch 2 times, most recently from c225a9e to 176b5e1 Compare July 10, 2023 09:12
@nabim777 nabim777 marked this pull request as ready for review July 10, 2023 09:14
@nabim777 nabim777 force-pushed the search-folder-tag branch 2 times, most recently from 1f90a01 to d6e06aa Compare July 10, 2023 10:01
@nabim777 nabim777 requested a review from grgprarup July 10, 2023 10:15
saw-jan
saw-jan reviewed Jul 10, 2023
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

others LGTM

SagarGi
SagarGi reviewed Jul 11, 2023
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@nabim777 nabim777 requested a review from grgprarup July 11, 2023 03:58
@sonarcloud
Copy link

sonarcloud bot commented Jul 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

grgprarup
grgprarup approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@grgprarup grgprarup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@grgprarup grgprarup merged commit 9ff5c5e into master Jul 11, 2023
@delete-merged-branch delete-merged-branch bot deleted the search-folder-tag branch July 11, 2023 06:03
ownclouders pushed a commit that referenced this pull request Jul 11, 2023
@grgprarup
Merge pull request #6725 from owncloud/search-folder-tag
3cbe075 
[tests-only][full-ci]add scenario for search folder tag
@nabim777 nabim777 mentioned this pull request Jul 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SagarGi SagarGi SagarGi left review comments

@grgprarup grgprarup grgprarup approved these changes

@saw-jan saw-jan saw-jan approved these changes

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

Assignees

@nabim777 nabim777

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nabim777 @grgprarup @SagarGi @saw-jan