Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci][ci] Wait for fakeoffice to be ready #6754

Merged
merged 1 commit into from
Jul 11, 2023
Merged

[tests-only][full-ci][ci] Wait for fakeoffice to be ready #6754

merged 1 commit into from
Jul 11, 2023

Conversation

PrajwolAmatya
Copy link
Contributor

@PrajwolAmatya PrajwolAmatya commented Jul 10, 2023 •
edited by saw-jan
Loading

Description

Sometimes the wopiValidation pipeline can fail due to the race condition between fakeoffice and ocis-server steps. This was due to running both steps parallelly. This PR adds the wait for fakeoffice service so that there won't be a race condition between fakeoffice and ocis-server steps.

Related Issue

fixes #6750

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@PrajwolAmatya PrajwolAmatya marked this pull request as draft July 10, 2023 09:11
@PrajwolAmatya PrajwolAmatya self-assigned this Jul 10, 2023
@PrajwolAmatya PrajwolAmatya force-pushed the wait-for-fake-office branch 2 times, most recently from 6d614eb to 27be9e5 Compare July 10, 2023 10:15
@PrajwolAmatya PrajwolAmatya marked this pull request as ready for review July 10, 2023 10:17
@PrajwolAmatya PrajwolAmatya changed the title [tests-only][full-ci]add wait for fake office [tests-only][full-ci]+revert changes of PR #6461 Jul 10, 2023
@PrajwolAmatya PrajwolAmatya changed the title [tests-only][full-ci]+revert changes of PR #6461 [tests-only][full-ci]revert changes of PR #6461 Jul 10, 2023
@PrajwolAmatya PrajwolAmatya force-pushed the wait-for-fake-office branch 3 times, most recently from 2ee63de to ae762c2 Compare July 10, 2023 11:09
@phil-davis
Copy link
Contributor

This looks like it only reverts one of the commits from #6416
e4f9633

Please explain in the top post of this PR about why we should change the order back. That will help people to understand what is happening in the CI.

@saw-jan
Copy link
Member

saw-jan commented Jul 10, 2023 •
edited
Loading

@PrajwolAmatya Also, prefix issues with fixes if this PR fixes them. So that closing issues manually won't be necessary

@saw-jan saw-jan requested a review from phil-davis July 10, 2023 11:40
@saw-jan saw-jan changed the title [tests-only][full-ci]revert changes of PR #6461 [tests-only][full-ci][ci] Run ocsi-server only after wopiserver is ready Jul 10, 2023
@saw-jan saw-jan changed the title [tests-only][full-ci][ci] Run ocsi-server only after wopiserver is ready [tests-only][full-ci][ci] Run ocis-server only after wopiserver is ready Jul 11, 2023
@saw-jan saw-jan changed the title [tests-only][full-ci][ci] Run ocis-server only after wopiserver is ready [tests-only][full-ci][ci] Wait for fakeoffice to be ready Jul 11, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

phil-davis
phil-davis approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saw-jan saw-jan merged commit f370d27 into master Jul 11, 2023
@delete-merged-branch delete-merged-branch bot deleted the wait-for-fake-office branch July 11, 2023 05:48
ownclouders pushed a commit that referenced this pull request Jul 11, 2023
@PrajwolAmatya
wait for fakeoffice to be ready (#6754)
ca82da4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

@saw-jan saw-jan Awaiting requested review from saw-jan

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

Assignees

@PrajwolAmatya PrajwolAmatya

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add step wait-for-fakeoffice to drone pipeline
3 participants
@PrajwolAmatya @phil-davis @saw-jan