-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
storage-users: Add config option for graceful shutdown timeout #6840
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
As just discussed with @rhafer, I am working on a commit to update the envvar text and a readme addon with an explanation. commit will come latest tomorrow morning. |
Add STORAGE_USERS_GRACEFUL_SHUTDOWN_TIMEOUT setting to allow a graceful shutdown of the storage-users service. This currently only applicable when running storage-user as a sepearate service. Setting STORAGE_USERS_GRACEFUL_SHUTDOWN_TIMEOUT to a non-zero value gives the storage-users service a chance to cleanly shutdown and finish any in progess tasks (e.g. metadata propagation) before exiting. Partial-Fix: #6602
@saw-jan did some tests to proof my writing:
|
Command [1] 174239 terminated STORAGE_USERS_GRACEFUL_SHUTDOWN_TIMEOUT=5 STORAGE_USERS_LOG_LEVEL=debug |
Co-authored-by: Edith Parzefall <edith_parzefall@gmx.de>
Co-authored-by: Edith Parzefall <edith_parzefall@gmx.de>
good point, will add that. |
Co-authored-by: Edith Parzefall <edith_parzefall@gmx.de>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from a docs pov 👍
storage-users: Add config option for graceful shutdown timeout
Add STORAGE_USERS_GRACEFUL_SHUTDOWN_TIMEOUT setting to allow an graceful shutdown of the storage-users service. This currently only applicable when running storage-user as a sepearate service.
Setting STORAGE_USERS_GRACEFUL_SHUTDOWN_TIMEOUT to a non-zero value gives the storage-users service a chance to cleanly shutdown and finish any in progess tasks (e.g. metadata propagation) before exiting.
Partial-Fix: #6602
Keeping this in draft for now, until the relate reva part is merged (cs3org/reva#4072)