Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check public link auth first #6900

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Check public link auth first #6900

merged 1 commit into from
Jul 27, 2023

Conversation

kobergj
Copy link
Collaborator

@kobergj kobergj commented Jul 26, 2023

Fixes #6887

@kobergj
check public link authorization first
af2a4c2 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

aduffeck
aduffeck approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@aduffeck aduffeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was a bit worried of potential performance impacts of that, but at a closer look the PublicShareAuthenticator seems to only do a bunch of prefix matches on non public-link URLs, so it should be fine.
lgtm

@kobergj kobergj merged commit 3fa8374 into owncloud:master Jul 27, 2023
@kobergj kobergj deleted the CheckPublicAuthFirst branch July 27, 2023 09:03
ownclouders pushed a commit that referenced this pull request Jul 27, 2023
@kobergj
Merge pull request #6900 from kobergj/CheckPublicAuthFirst
68a7263 
Check public link auth first
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fschade fschade fschade approved these changes

@dragonchaser dragonchaser dragonchaser approved these changes

@aduffeck aduffeck aduffeck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Public link. authorized user cannot open file in Onlyoffice
4 participants
@kobergj @aduffeck @dragonchaser @fschade