Theme konnectd #698

LukasHirt · 2020-10-14T11:34:36Z

Bring konnectd frontend, create ownCloud theme and generate assets.

Open tasks:

Changelog item
Replace placeholder logo with the ownCloud one when generating
Bring ownCloud favicon when generating

update-docs · 2020-10-14T11:34:40Z

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

LukasHirt · 2020-10-14T11:35:58Z

There are some parts of the frontend which are probably not required but were causing a lot of errors when removed. I'd like to go in a separate PR through them when there'd more time and do some followup cleanup.

LukasHirt · 2020-10-14T12:34:03Z

@micbar Have you got some idea why this line is not respected by codacy https://github.com/owncloud/ocis/pull/698/files#diff-3404650b2859b064f8b0527d200936d6b306cf8e11437f0051b38af5aeaab1c2R4 and the error in webpack config is still showing up?

micbar · 2020-10-14T13:06:18Z

@LukasHirt this file is no longer used.

Use the top level one and adapt the paths

micbar · 2020-10-14T13:08:08Z

same for the .gitignore

kulmann · 2020-10-15T05:54:57Z

@LukasHirt please rebase to current master. A grpc-ecosystem package that we are using in some Makefiles has been renamed => already adjusted on master.

LukasHirt · 2020-10-15T07:59:54Z

please rebase to current master. A grpc-ecosystem package that we are using in some Makefiles has been renamed => already adjusted on master.

Done 😉

LukasHirt · 2020-10-15T08:32:31Z

Use the top level one and adapt the paths

Still getting the error even though I moved it in there 😞

.codacy.yml

kulmann

Noticed some things:

file konnectd/ui/src/images/owncloud-logo.svg is part of this PR and should be removed or some placeholder image, right?
There are some files from the original kopano theme (augmenting teamwork, etc) which could be removed
The font size of the input fields is too small. It should be 1rem, but is 0.8...rem. With the current size it looks weird coming from the login form with tiny font size to ownCloud Web with quite big font size.

LukasHirt · 2020-10-19T07:45:30Z

file konnectd/ui/src/images/owncloud-logo.svg is part of this PR and should be removed or some placeholder image, right?

Right, thanks!

There are some files from the original kopano theme (augmenting teamwork, etc) which could be removed

I removed leftover images for now but regarding other files is this comment:

There are some parts of the frontend which are probably not required but were causing a lot of errors when removed. I'd like to go in a separate PR through them when there'd more time and do some followup cleanup.

The font size of the input fields is too small. It should be 1rem, but is 0.8...rem. With the current size it looks weird coming from the login form with tiny font size to ownCloud Web with quite big font size.

Per request from the marketing team, I have adjusted this according to the ownCloud website form inputs where it is the same font size.

kulmann · 2020-10-19T07:50:39Z

The font size of the input fields is too small. It should be 1rem, but is 0.8...rem. With the current size it looks weird coming from the login form with tiny font size to ownCloud Web with quite big font size.

Per request from the marketing team, I have adjusted this according to the ownCloud website form inputs where it is the same font size.

Hm... I don't agree. 😅 Styling the login page should be consistent with phoenix, not the website. 👀 We're going back and forth between phoenix and the login page, the website is never part of this process.

If styles of the input elements should be adjusted in general, that's a different story. But breaking style consistency within a user workflow is a no go IMO.

refs

First of all, huge PR 👏 I took a look mostly at the react components, leaving build stuff out, and just a matter of consistency and a suggestion for using TypeScript 🤓 . Haven't tried the PR locally, intending to do so later today.

konnectd/ui/src/components/Loading.js

refs · 2020-10-19T07:56:15Z

konnectd/ui/src/components/Loading.js

@@ -0,0 +1,93 @@
+import React from 'react';
+import PropTypes from 'prop-types';
+import { connect } from 'react-redux';


haven't worked with Vuex, only with redux, but wouldn't it be better to use vuex + react instead of adding another store? Curious :D

This would create extra dependency on Vue, wouldn't it? At least when looking at https://www.npmjs.com/package/react-vuex that's the feeling I am getting

refs · 2020-10-19T08:02:17Z

konnectd/ui/src/containers/Goodbye/Goodbyescreen.js

+  }
+}
+
+Goodbyescreen.propTypes = {


Is using TS an option? https://www.typescriptlang.org/docs/handbook/migrating-from-javascript.html#moving-to-typescript-files

I'd very much love that! Not sure if I can introduce in one PR not only react but TS as well though 🙈 Maybe that'd be too much?

konnectd/ui/src/containers/Login/Chooseaccount.js

LukasHirt · 2020-10-19T09:44:18Z

Addressed your comments @refs and increased font size and changed the height of inputs to reflect the other ones in ocis-web @kulmann Thank you both for reviews! I've rebased the PR also so hopefully the random API tests failures will be gone.

Add new line at the end of file Shorten hex Add zero

kulmann

🚀

kulmann · 2020-10-19T14:27:52Z

love it!

sonarqubecloud · 2020-10-19T20:03:34Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

No Coverage information
No Duplication information

Merge: eb31510 b8f64ce Author: Lukas Hirt <lhirt@owncloud.com> Date: Tue Oct 20 00:32:05 2020 +0200 Merge pull request #698 from owncloud/branded-kopano

LukasHirt added the enhancement label Oct 14, 2020

LukasHirt requested a review from kulmann October 14, 2020 11:34

LukasHirt self-assigned this Oct 14, 2020

LukasHirt force-pushed the branded-kopano branch from 7e553e6 to a530c97 Compare October 14, 2020 11:53

LukasHirt force-pushed the branded-kopano branch from 12580bb to e4c5ee8 Compare October 15, 2020 07:59

micbar reviewed Oct 16, 2020

View reviewed changes

.codacy.yml Outdated Show resolved Hide resolved

LukasHirt force-pushed the branded-kopano branch from 07f8184 to 717eb87 Compare October 18, 2020 18:10

kulmann suggested changes Oct 19, 2020

View reviewed changes

refs approved these changes Oct 19, 2020

View reviewed changes

LukasHirt added 11 commits October 19, 2020 11:41

Theme konnectd

c266f0c

Add codacy config with excluding paths

42c189c

Update assets

416816a

Adjust paths in codacy exclude

8b97e6d

Move konnectd codacy config to the root

813fa28

Add yarn logs into gitignore

50d040d

Adjust styles of form

f6442f2

Add assets to gitignore

970ef7c

Pull oC logo and favicon

e1cdb36

Adjust logo size

75129e8

Fix favicon var and codacy ignore patterns

ba65ed4

LukasHirt added 9 commits October 19, 2020 11:41

Add PHONY

a559698

Small design tweaks

7c3ad10

Create static folder

fbe36ff

Remove unused images

82b7b56

Turn loading component into FC

f2362a6

Adjust loading page styles

52d3c76

Increase input font size

20dcd87

Turn chooseaccount into FC

b324b08

Properly use scoping

46ea80c

LukasHirt force-pushed the branded-kopano branch from 074a268 to 46ea80c Compare October 19, 2020 09:42

LukasHirt force-pushed the branded-kopano branch from 68fcd54 to e7979ba Compare October 19, 2020 09:45

Fix codacy error

175b90b

Add new line at the end of file Shorten hex Add zero

LukasHirt force-pushed the branded-kopano branch from e7979ba to 175b90b Compare October 19, 2020 09:51

micbar requested a review from kulmann October 19, 2020 14:18

kulmann approved these changes Oct 19, 2020

View reviewed changes

Merge branch 'master' into branded-kopano

b8f64ce

LukasHirt merged commit a2823a0 into master Oct 19, 2020

LukasHirt deleted the branded-kopano branch October 19, 2020 22:32

ownclouders pushed a commit that referenced this pull request Oct 19, 2020

commit a2823a0

ae6b47a

Merge: eb31510 b8f64ce Author: Lukas Hirt <lhirt@owncloud.com> Date: Tue Oct 20 00:32:05 2020 +0200 Merge pull request #698 from owncloud/branded-kopano

This was referenced Nov 16, 2020

[QA] account chooser prints black text on dark blue background #864

Closed

[QA] Desktop client re-login is attempted with last WEB UI user #865

Closed

micbar mentioned this pull request Dec 16, 2020

[with-benchmarks] Merge back after 1.0.0 Release #1117

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Theme konnectd #698

Theme konnectd #698

LukasHirt commented Oct 14, 2020 •

edited

Loading

update-docs bot commented Oct 14, 2020

LukasHirt commented Oct 14, 2020

LukasHirt commented Oct 14, 2020

micbar commented Oct 14, 2020

micbar commented Oct 14, 2020

kulmann commented Oct 15, 2020

LukasHirt commented Oct 15, 2020

LukasHirt commented Oct 15, 2020

kulmann left a comment

LukasHirt commented Oct 19, 2020

kulmann commented Oct 19, 2020 •

edited

Loading

refs left a comment

refs Oct 19, 2020

LukasHirt Oct 19, 2020

refs Oct 19, 2020

LukasHirt Oct 19, 2020 •

edited

Loading

LukasHirt commented Oct 19, 2020

kulmann left a comment

kulmann commented Oct 19, 2020

sonarqubecloud bot commented Oct 19, 2020

Theme konnectd #698

Theme konnectd #698

Conversation

LukasHirt commented Oct 14, 2020 • edited Loading

Open tasks:

update-docs bot commented Oct 14, 2020

LukasHirt commented Oct 14, 2020

LukasHirt commented Oct 14, 2020

micbar commented Oct 14, 2020

micbar commented Oct 14, 2020

kulmann commented Oct 15, 2020

LukasHirt commented Oct 15, 2020

LukasHirt commented Oct 15, 2020

kulmann left a comment

Choose a reason for hiding this comment

LukasHirt commented Oct 19, 2020

kulmann commented Oct 19, 2020 • edited Loading

refs left a comment

Choose a reason for hiding this comment

refs Oct 19, 2020

Choose a reason for hiding this comment

LukasHirt Oct 19, 2020

Choose a reason for hiding this comment

refs Oct 19, 2020

Choose a reason for hiding this comment

LukasHirt Oct 19, 2020 • edited Loading

Choose a reason for hiding this comment

LukasHirt commented Oct 19, 2020

kulmann left a comment

Choose a reason for hiding this comment

kulmann commented Oct 19, 2020

sonarqubecloud bot commented Oct 19, 2020

LukasHirt commented Oct 14, 2020 •

edited

Loading

kulmann commented Oct 19, 2020 •

edited

Loading

LukasHirt Oct 19, 2020 •

edited

Loading