-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement: add sse service skeleton #6992
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kobergj
force-pushed
the
sse-service
branch
3 times, most recently
from
August 18, 2023 12:39
76f80eb
to
eb9f124
Compare
This was referenced Aug 18, 2023
|
kobergj
force-pushed
the
sse-service
branch
2 times, most recently
from
August 21, 2023 11:31
e1dca56
to
5226153
Compare
mmattel
reviewed
Aug 21, 2023
kobergj
force-pushed
the
sse-service
branch
3 times, most recently
from
August 28, 2023 09:27
6d64c9e
to
8f7b855
Compare
kobergj
requested review from
wkloucek,
micbar,
phil-davis and
individual-it
as code owners
August 28, 2023 09:28
Signed-off-by: jkoberg <jkoberg@owncloud.com>
Signed-off-by: jkoberg <jkoberg@owncloud.com>
Signed-off-by: jkoberg <jkoberg@owncloud.com>
Kudos, SonarCloud Quality Gate passed! |
2403905
approved these changes
Aug 29, 2023
ownclouders
pushed a commit
that referenced
this pull request
Aug 30, 2023
enhancement: add sse service skeleton
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
So far, SSE has only been used to exchange content type messages between the server and the client.
In order to be able to send more content (and context) to the client, we have moved the endpoint to a separate service and are now also using it for other notifications like:
Related Issue
Motivation and Context
First SSE POC was build as part of our christmas hacking and is used as a content messaging (no context) layer only at the moment, this is nice but does not show or use the whole potential of that endpoint.
To do so, and also make our clients more interactive (RIP F4), we start to use it for other notifications more and more.
For the moment we should not rely on SSE exclusively for business critical communications, that's why we're going on two tracks for the moment.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: