Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci]refactoring the tag creating step using data table #7051

Merged

Conversation

nabim777
Copy link
Member

@nabim777 nabim777 commented Aug 17, 2023

Description

This PR consists of refactoring created tags step where multiple tags are created for a file.

Related Issues

#6606 (comment)

Motivation and Context

several tags may only be added to one file at a time in the previous step, thus that step must be repeated in order to add tags to several files. That will lengthen the scenario.
So, a new step has been added in which several tags can be placed in multiple files at once and it will cut short the length of the scenario

How Has This Been Tested?

  • test environment:
  • locally
  • ci

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@nabim777 nabim777 force-pushed the refactoring-steps-creating-tag-with-example-tables branch 2 times, most recently from 64cb840 to 9781416 Compare August 17, 2023 10:14
@nabim777 nabim777 force-pushed the refactoring-steps-creating-tag-with-example-tables branch from 9781416 to 5f1c54e Compare August 17, 2023 11:32
@nabim777 nabim777 requested a review from saw-jan August 17, 2023 11:35
@nabim777 nabim777 force-pushed the refactoring-steps-creating-tag-with-example-tables branch from 5f1c54e to 53a49ee Compare August 18, 2023 02:51
@sonarcloud
Copy link

sonarcloud bot commented Aug 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nabim777 nabim777 requested a review from saw-jan August 18, 2023 10:56
Copy link
Contributor

@amrita-shrestha amrita-shrestha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@amrita-shrestha amrita-shrestha merged commit 63bb316 into master Aug 18, 2023
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the refactoring-steps-creating-tag-with-example-tables branch August 18, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants