-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests-only][full-ci]refactoring the tag creating step using data table #7051
Merged
amrita-shrestha
merged 1 commit into
master
from
refactoring-steps-creating-tag-with-example-tables
Aug 18, 2023
Merged
[tests-only][full-ci]refactoring the tag creating step using data table #7051
amrita-shrestha
merged 1 commit into
master
from
refactoring-steps-creating-tag-with-example-tables
Aug 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabim777
requested review from
grgprarup,
SwikritiT,
SagarGi,
saw-jan,
amrita-shrestha and
PrajwolAmatya
August 17, 2023 05:14
saw-jan
reviewed
Aug 17, 2023
saw-jan
reviewed
Aug 17, 2023
nabim777
force-pushed
the
refactoring-steps-creating-tag-with-example-tables
branch
2 times, most recently
from
August 17, 2023 10:14
64cb840
to
9781416
Compare
saw-jan
reviewed
Aug 17, 2023
nabim777
force-pushed
the
refactoring-steps-creating-tag-with-example-tables
branch
from
August 17, 2023 11:32
9781416
to
5f1c54e
Compare
saw-jan
reviewed
Aug 17, 2023
nabim777
force-pushed
the
refactoring-steps-creating-tag-with-example-tables
branch
from
August 18, 2023 02:51
5f1c54e
to
53a49ee
Compare
Kudos, SonarCloud Quality Gate passed! |
saw-jan
reviewed
Aug 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
amrita-shrestha
approved these changes
Aug 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
delete-merged-branch
bot
deleted the
refactoring-steps-creating-tag-with-example-tables
branch
August 18, 2023 10:59
ownclouders
pushed a commit
that referenced
this pull request
Aug 18, 2023
ownclouders
pushed a commit
that referenced
this pull request
Aug 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR consists of refactoring
created tags
step where multiple tags are created for a file.Related Issues
#6606 (comment)
Motivation and Context
several tags may only be added to one file at a time in the previous step, thus that step must be repeated in order to add tags to several files. That will lengthen the scenario.
So, a new step has been added in which several tags can be placed in multiple files at once and it will cut short the length of the scenario
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: