Auto Accept Shares

[kobergj]

Auto accepts shares when configured

Fixes #4834

According to story auto-accept should be true by default, but test pipeline cannot handle this for now. Steps to test auto acceptance:

• Make sure service accounts are enabled by setting OCIS_SERVICE_ACCOUNT_ID and OCIS_SERVICE_ACCOUNT_SECRET (or running ocis init on a fresh system)
• Enable auto-accept by setting FRONTEND_AUTO_ACCEPT_SHARES to true
• Disable auto-accept for einstein:

curl --insecure -X POST -u einstein:relativity https://localhost:9200/api/v0/settings/values-save -d '{"value":{"accountUuid":"me","bundleId":"2a506de7-99bd-4f0d-994e-c38e72c28fd9","settingId":"ec3ed4a3-3946-4efc-8f9f-76d38b12d3a9","resource":{"type":"TYPE_USER"},"boolValue":false}}'

• share a file with physics-lovers
• login with marie -> Her share is accepted
• login with einstein -> His share is not accepted

Note: Share acception is done asynchronously so there is a short gap between the creation of the share and the accept. This should not be visible on manual testing.

[update-docs]

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

[mmattel]

Looks good from a docs pov 👍

[fschade]

Code ✅
Tested ✅

would be nice to have it covered in ci... cc.: @individual-it

LGTM 🚀

[saw-jan]

would be nice to have it covered in ci... cc.: @individual-it

I have opened a ticket to add test coverage: #7241
We will be working on it.

[saw-jan]

According to story auto-accept should be true by default, but test pipeline cannot handle this for now

@kobergj, if it's required to be enabled by default in oCIS then maybe enable it by default and run tests with FRONTEND_AUTO_ACCEPT_SHARES=false for now, the later we can fix the tests and remove FRONTEND_AUTO_ACCEPT_SHARES=false. And we add some test scenarios with FRONTEND_AUTO_ACCEPT_SHARES=false.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information