support AD FS #7140
Merged
support AD FS #7140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
rhafer
approved these changes
Aug 29, 2023
kobergj
requested changes
Aug 29, 2023
Co-authored-by: kobergj <jkoberg@owncloud.com>
kobergj
approved these changes
Aug 30, 2023
|
Kudos, SonarCloud Quality Gate passed! |
ownclouders
pushed a commit
that referenced
this pull request
Sep 1, 2023
* support AD FS Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * drop unnecessary else Co-authored-by: kobergj <jkoberg@owncloud.com> --------- Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> Co-authored-by: kobergj <jkoberg@owncloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AD FS
/adfs/.well-known/openid-configurationhas an optionalaccess_token_issuerwhich, in violation of the OpenID Connect spec, takes precedence overissuer.Even MS had to patch its own clients: https://jpassing.com/2022/02/04/using-adfs-access-tokens-for-workload-identity-federation/