Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] enhancement: use kql as default search query language #7196

Closed
wants to merge 11 commits into from

Conversation

fschade
Copy link
Contributor

@fschade fschade commented Sep 1, 2023

Description

follow up pr for #7043, this enables and uses the kql query language as the default dialect for search queries.

enabled for the following endpoints (used by web as default):~~

  • /remote.php/dav/spaces*
  • /dav/spaces*
  • /remote.php/dav/files*
  • /dav/files*

the endpoints /remote.php/dav/files* and /dav/files* are not affected by this and continue to use the legacy query format.

Related Issue

Motivation and Context

https://github.com/owncloud/ocis/blob/master/docs/ocis/adr/0020-file-search-query-language.md

How Has This Been Tested?

  • unit tests
  • acceptance tests

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Todo:

  • Add tests for Bleve <-> KQL
  • Fix Tests for the legacy query format
  • Add new unit tests
  • Add new acceptance tests

@fschade fschade changed the title enhancement: use kql as default search query language [full-ci] enhancement: use kql as default search query language Sep 2, 2023
@fschade fschade force-pushed the enable-kql branch 2 times, most recently from 60f350d to efbc05a Compare September 3, 2023 08:41
@sonarcloud
Copy link

sonarcloud bot commented Sep 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

85.7% 85.7% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant