Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci]Add test for searching content across files with different format with search text highlight #7236

Merged
merged 1 commit into from
Sep 15, 2023
Merged

[tests-only][full-ci]Add test for searching content across files with different format with search text highlight #7236

merged 1 commit into from
Sep 15, 2023

Conversation

SwikritiT
Copy link
Contributor

Description

This PR adds test for searching content across files with different formats

Related Issue

How Has This Been Tested?

  • locally
  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@SwikritiT SwikritiT self-assigned this Sep 6, 2023
@SwikritiT SwikritiT force-pushed the tests/search-file-content-different-file-formats branch from df234b2 to 8cdbaf4 Compare September 6, 2023 11:02
@SwikritiT SwikritiT mentioned this pull request Sep 6, 2023
Closed
51 tasks
@ScharfViktor
Copy link
Contributor

@SwikritiT could you please check highlights

this feature:

Screenshot 2023-09-06 at 13 56 17

just keep in mind that not all characters we can find. see bug: #6674

@SwikritiT
Copy link
Contributor Author

@SwikritiT could you please check highlights

this feature:

Screenshot 2023-09-06 at 13 56 17

just keep in mind that not all characters we can find. see bug: #6674

sure!

SagarGi
SagarGi reviewed Sep 7, 2023
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scenarios LGTM 👍

@SwikritiT SwikritiT force-pushed the tests/search-file-content-different-file-formats branch 2 times, most recently from fda7b00 to 2f182a0 Compare September 14, 2023 10:31
@SwikritiT SwikritiT changed the title [tests-only][full-ci]Add test for searching content across files with different format [tests-only][full-ci]Add test for searching content across files with different format with search text highlight Sep 14, 2023
@SwikritiT SwikritiT force-pushed the tests/search-file-content-different-file-formats branch from 1652479 to f26d03e Compare September 14, 2023 11:02
saw-jan
saw-jan approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SwikritiT SwikritiT force-pushed the tests/search-file-content-different-file-formats branch from f1d03bc to 6e93b4b Compare September 15, 2023 03:48
@SwikritiT SwikritiT force-pushed the tests/search-file-content-different-file-formats branch from 6e93b4b to 61388fc Compare September 15, 2023 08:27
@sonarcloud
Copy link

sonarcloud bot commented Sep 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@saw-jan saw-jan merged commit 8bad22c into master Sep 15, 2023
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the tests/search-file-content-different-file-formats branch September 15, 2023 09:46
ownclouders pushed a commit that referenced this pull request Sep 15, 2023
@SwikritiT
Add test for searching content across files with different format wit…
dc4114c 
…h search text highlight (#7236)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan approved these changes

@ScharfViktor ScharfViktor ScharfViktor approved these changes

@grgprarup grgprarup Awaiting requested review from grgprarup

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

@SagarGi SagarGi Awaiting requested review from SagarGi

@nabim777 nabim777 Awaiting requested review from nabim777

Assignees

@SwikritiT SwikritiT

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SwikritiT @ScharfViktor @SagarGi @saw-jan @nabim777