Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use service user for role assignment and autoprovisioning #7240

Merged
merged 4 commits into from
Sep 7, 2023

Conversation

rhafer
Copy link
Contributor

@rhafer rhafer commented Sep 6, 2023

This gets us a rid of the need to configure the reva jwt secret in the proxy. Also we no longer need to fake an internal admin user for autoprovsioning user and/or assigning the roles to users from oidc claims.

@rhafer rhafer requested a review from kobergj September 6, 2023 13:25
@rhafer rhafer self-assigned this Sep 6, 2023
@rhafer rhafer force-pushed the proxy-service-account branch 2 times, most recently from ac3439b to fb1ef3b Compare September 6, 2023 13:26
Copy link
Collaborator

@kobergj kobergj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👍 Just small question

services/proxy/pkg/user/backend/cs3.go Outdated Show resolved Hide resolved
@rhafer rhafer force-pushed the proxy-service-account branch from fb1ef3b to 193e631 Compare September 7, 2023 08:50
@rhafer rhafer requested a review from kobergj September 7, 2023 08:51
Copy link
Collaborator

@kobergj kobergj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rhafer rhafer force-pushed the proxy-service-account branch 2 times, most recently from 63bc3e0 to 9417a3b Compare September 7, 2023 14:35
This gets us a rid of the need to configure the reva jwt secret in the
proxy. Also we no longer need to fake an internal admin user for
autoprovsioning user and/or assigning the roles to users from oidc
claims.
@rhafer rhafer force-pushed the proxy-service-account branch from 9417a3b to dadb1f4 Compare September 7, 2023 15:32
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@rhafer rhafer merged commit a01f5d9 into owncloud:master Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants