Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update reva to dd3a8c0f38 #725

Merged
merged 2 commits into from
Oct 21, 2020
Merged

update reva to dd3a8c0f38 #725

merged 2 commits into from
Oct 21, 2020

Conversation

butonic
Copy link
Member

@butonic butonic commented Oct 21, 2020 •
edited
Loading

  • changelog ... really? @micbar version updates are enhancements, right? and they go into the root changelog, right?

@update-docs
Copy link

update-docs bot commented Oct 21, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@butonic butonic force-pushed the update-reva-to-dd3a8c0f38 branch from 78c3bd7 to 8f79c16 Compare October 21, 2020 15:51
@phil-davis
Copy link
Contributor

https://drone.owncloud.com/owncloud/ocis/820/25/7

Checking expected failures for suite apiWebdavEtagPropagation1
Error: Scenario apiWebdavEtagPropagation1/moveFileFolder.feature:20 was expected to fail but did not fail.
Error: Scenario apiWebdavEtagPropagation1/moveFileFolder.feature:21 was expected to fail but did not fail.
Error: Scenario apiWebdavEtagPropagation1/moveFileFolder.feature:58 was expected to fail but did not fail.
Error: Scenario apiWebdavEtagPropagation1/moveFileFolder.feature:59 was expected to fail but did not fail.
Error: Scenario apiWebdavEtagPropagation1/moveFileFolder.feature:74 was expected to fail but did not fail.
Error: Scenario apiWebdavEtagPropagation1/moveFileFolder.feature:75 was expected to fail but did not fail.
Error: Scenario apiWebdavEtagPropagation1/moveFileFolder.feature:93 was expected to fail but did not fail.
Error: Scenario apiWebdavEtagPropagation1/moveFileFolder.feature:94 was expected to fail but did not fail.
Error: Scenario apiWebdavEtagPropagation1/moveFileFolder.feature:112 was expected to fail but did not fail.
Error: Scenario apiWebdavEtagPropagation1/moveFileFolder.feature:113 was expected to fail but did not fail.
Error: Scenario apiWebdavEtagPropagation1/moveFileFolder.feature:306 was expected to fail but did not fail.
Error: Scenario apiWebdavEtagPropagation1/moveFileFolder.feature:321 was expected to fail but did not fail.
Error: Scenario apiWebdavEtagPropagation1/moveFileFolder.feature:39 was expected to fail but did not fail.
Error: Scenario apiWebdavEtagPropagation1/moveFileFolder.feature:40 was expected to fail but did not fail.
Error: Scenario apiWebdavEtagPropagation1/moveFileFolder.feature:201 was expected to fail but did not fail.
Error: Scenario apiWebdavEtagPropagation1/moveFileFolder.feature:202 was expected to fail but did not fail.
Error: Scenario apiWebdavEtagPropagation1/moveFileFolder.feature:269 was expected to fail but did not fail.
Error: Scenario apiWebdavEtagPropagation1/moveFileFolder.feature:270 was expected to fail but did not fail.
Failure - actual and expected failures did not match

That's good news - those tests are passing now. The lines can be deleted from the expected-failures file.

@butonic
update reva to dd3a8c0
8be53d6 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
update expected tests
01c6314 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic butonic force-pushed the update-reva-to-dd3a8c0f38 branch from 0811710 to 01c6314 Compare October 21, 2020 18:31
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

micbar
micbar approved these changes Oct 21, 2020
View reviewed changes
Copy link
Contributor

@micbar micbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@micbar micbar merged commit bd315f6 into owncloud:master Oct 21, 2020
ownclouders pushed a commit that referenced this pull request Oct 21, 2020
@micbar
commit bd315f6
edd8ed2 
Merge: 64f057c 01c6314
Author: Michael Barz <mbarz@owncloud.com>
Date:   Wed Oct 21 22:22:17 2020 +0200

    Merge pull request #725 from butonic/update-reva-to-dd3a8c0f38

    update reva to dd3a8c0
@butonic butonic deleted the update-reva-to-dd3a8c0f38 branch October 22, 2020 05:55
@phil-davis phil-davis mentioned this pull request Oct 26, 2020
Closed
@micbar micbar mentioned this pull request Dec 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micbar micbar micbar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@butonic @phil-davis @micbar