Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify storage driver env vars #729

Merged
merged 1 commit into from
Oct 23, 2020
Merged

Clarify storage driver env vars #729

merged 1 commit into from
Oct 23, 2020

Conversation

butonic
Copy link
Member

@butonic butonic commented Oct 22, 2020

After renaming ocsi-reva to storage and combining the storage and data providers some env vars were confusingly named STORAGE_STORAGE_.... We are changing the prefix for driver related env vars to STORAGE_DRIVER_.... This makes changing the storage driver using eg.: STORAGE_HOME_DRIVER=eos and setting driver options using STORAGE_DRIVER_EOS_LAYOUT=... less confusing.

@butonic butonic requested review from micbar, individual-it and C0rby and removed request for micbar October 22, 2020 10:01
@phil-davis
Copy link
Contributor

In https://github.com/owncloud/ocis/blob/master/storage/pkg/flagset/gateway.go I can also still find:
STORAGE_STORAGE_REGISTRY_DRIVER
STORAGE_STORAGE_REGISTRY_RULES

https://github.com/owncloud/ocis/blob/master/docs/extensions/storage/configuration.md has lots of STORAGE_STORAGE* - should those all be replaced with just STORAGE* ?

@butonic butonic force-pushed the clarify-storage-driver-env-vars branch from e265078 to e3309d6 Compare October 22, 2020 10:39
@butonic
Copy link
Member Author

butonic commented Oct 22, 2020

Unfortunately, there is not only a storage registry in reva, but also an appregistry ... the prefix is STORAGE, that is why I left

STORAGE_STORAGE_REGISTRY_DRIVER
STORAGE_STORAGE_REGISTRY_RULES

unchanged ...

@butonic
Copy link
Member Author

butonic commented Oct 22, 2020

@micbar doesn't the configuration.md get generated?

@micbar
Copy link
Contributor

micbar commented Oct 22, 2020

@micbar doesn't the configuration.md get generated?

Yes is does. We could delete it from git.

@individual-it
Copy link
Member

we need also to adjust CI in phoenix, maybe after owncloud/web#4228 gets merged

@butonic butonic force-pushed the clarify-storage-driver-env-vars branch 6 times, most recently from fb19ff9 to 1c22a41 Compare October 23, 2020 14:58
@butonic butonic force-pushed the clarify-storage-driver-env-vars branch 2 times, most recently from 87b2aba to 69aa1ee Compare October 23, 2020 20:34
@butonic
Clarify storage driver env vars
8eb0864 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic butonic force-pushed the clarify-storage-driver-env-vars branch from 69aa1ee to 8eb0864 Compare October 23, 2020 20:48
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@butonic butonic merged commit 17a180e into owncloud:master Oct 23, 2020
@butonic butonic deleted the clarify-storage-driver-env-vars branch October 23, 2020 21:38
@individual-it individual-it mentioned this pull request Nov 18, 2020
Merged
@micbar micbar mentioned this pull request Dec 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IljaN IljaN IljaN approved these changes

@individual-it individual-it Awaiting requested review from individual-it individual-it is a code owner

@micbar micbar Awaiting requested review from micbar

@C0rby C0rby Awaiting requested review from C0rby

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@butonic @phil-davis @micbar @individual-it @IljaN